Allow specifying request headers in RasterOverlayOptions
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of using the existing constructor parameters for headers, as used in CesiumGS/cesium-unreal#1597. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067. This is a companion to #1057, applying a similar change to raster overlays. One wrinkle in the implementation is that some raster overlays already accept headers in their constructor. Not only would it be best to avoid changing the public API, but
IonRasterOverlayin particular relies on this functionality being present so it can pass theAuthorizationheader to the underlyingTileMapServiceRasterOverlay. To support this, I've added amergeHeadersmethod that allows the headers specified in the constructor to override any headers with the same name specified in theRasterOverlayOptions.