Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #11507 (JulianDate.toIso8601 builds a non compliant string with very small milliseconds) #12345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jfayot
Copy link
Contributor

@jfayot jfayot commented Nov 28, 2024

Description

This PR fixes the issue related to building ISO8601 date string from a JulianDate object with very small fractional seconds.

Issue number and link

Fixes #11507

Testing plan

  • Added test case "toIso8601 works with very small milliseconds" in JulianDateSpec.js

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

…mpliant string with very small milliseconds)
Copy link

Thank you for the pull request, @jfayot!

✅ We can confirm we have a CLA on file for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JulianDate.toIso8601 builds a non compliant string with very small milliseconds
1 participant