Skip to content

Commit

Permalink
chore: bump rubocop version to 1.58 and correct offenses (#3795)
Browse files Browse the repository at this point in the history
  • Loading branch information
jdjaustin authored Dec 5, 2023
1 parent 4c2e7dd commit 1d1c04c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scripts-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
ruby-version: '3.0'
- name: Run rubocop
run: |
gem install rubocop -v 1.57 --no-document
gem install rubocop -v 1.58 --no-document
rubocop scripts/
run-js-linters:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions scripts/linters/find_unused_deps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ def excluded?(crates, crate)
crate_dir = File.dirname(file)
toml = TomlRB.load_file(file)
crates = Set.new
toml['dependencies']&.each do |crate_name, _|
toml['dependencies']&.each_key do |crate_name|
crates.add crate_name
end
toml['dev-dependencies']&.each do |crate_name, _|
toml['dev-dependencies']&.each_key do |crate_name|
crates.add crate_name
end
if toml['workspace']
toml['workspace']['dependencies']&.each do |crate_name, _|
toml['workspace']['dependencies']&.each_key do |crate_name|
crates.add crate_name
end
end
Expand Down

0 comments on commit 1d1c04c

Please sign in to comment.