Lightning Trait Changed, Models Generated and General Cleanup #12
Conversation
Log of changes: - Updated the lightning weapons to call down lightning instead of just doing lightning damage - Updated the model generator Python script and generated all models - Cleaned up a few unnecessary files (including those updated by newer variants or are just no longer required) - Moved the logo file to mod.toml friendly location and updated the Git readme to reference this logo for the title - renamed battlehammer_* textures back to hammer_* after finding out that SpartanWeaponry updated the name but not the resource name To Do: - Create new Lightning weapon textures - Fix Tooltips, currently the item name and trait is being shown as a resource location - Fix Model generators, currently this is believed to be held back by the IaF bug raised in Issue #4214 in IaF repo - Potentially create Recipe generators, still a little unsure how to do this with items created using SpartanWeaponry API
Log of changes: - deobf of SpartanWeaponry disabled, not required as only public API is used - Fix item registry - Rename textures/item to textures/items to be in correct location for models - standard item, witherbone handle and witherbone pole models are not created by Python script, manually created See previous commit 9e72edb for "To Do" list
Log of Changes: - Cleanup in main registry file, moved the colours which are static between all materials to within the Util script and removed the parameters - Created a Python Lang file generator and created a new Lang file in json format following the weapon naming conventions from IaF
Log of Changes: - Small change in lang generator and file, change lightning trait description to in-line with IaF wording. Not sure if I should remove the glowing effect, it's not part of IaF it was just a personal touch. - Fix bow models and generator, there was an item/items mis-naming
|
Just because it's been a bit since an update, there are a few things
|
|
@XxInvictus @Kovak Please look at this: #16 -> There are the lightning weapon textures, made by Samlegamer. |
|
hey guys sorry I've been a bit busy with work, where are we at on this one? is it ready for me to take a look? |
|
Hi @Kovak, its fine! Aparently its not far to become good enough to a public release, but unfortunately @XxInvictus has not been active on github for a while, so i dont know if this great port is dead or not. And there is another port: minhtet-htoon/SaF2021#1 (unnoficial). But the dev unfortunately dont have time to finish the work |
|
It is a mix of my work got busier and also the updates stagnated on things outside of my control. The status hasn't changed since I last updated, below is a summary. To get it working "good enough" all that is missing is Textures for lightning gear, reached out to Javaraptor a couple of times and he did have interest but was busy. The other two items there is no change:
|
|
Hi @XxInvictus . Of course. I would love to use this mod in 1.16.5. Maybe i can help with something: #16 (There are all the lightning weapon textures, made by Samlegamer) And i talked a bit with ObliviousSpartan(DM in CurseForge) about other things a few days ago, i can send a new message about this problem. |
|
Understandable that textures exist but Javaraptor would be ideal, as he is the one that not only did the textures for SpartanFire originally but he is also the one that does textures for IAF |
|
Yeah, i understand. But is something wrong to use these textures?(they look really good. Take a look at the lighting dragonsteel ones) I mean, if the main problem is that you dont have the textures and JavaRaptor is busy to make them, why not to use these? I think it's unfair considering your and Kovak hardwork to make this port becomes real, and a lot of people (also Samlegamer) wants this mod in 1.16.5...I really understand your point but if this reason "can make the port not happen", for me it doesn't make sense. |
|
Yeah i agree, you can use the textures made by samlegamer as a replacement till JavaRaptor does it |
|
Exactly. And I know that Xxinvictus wants this to be perfect, but its has been almost 4 months...And after all this is a open source minecraft project, please, let the community help you a bit! |
|
Exactly, it's an open source project, there is nothing stopping either of you contributing. As I said, I have work to focus on. I was just listing where it was up to and the preferred outcome. |
|
So it looks like the biggest thing we're waiting on is that update from Spartan Weaponry. We'll definitely make use of Samlegamer's textures. |
Renamed and included Lightning weapon textures provided by Samlegamer
|
I honestly don't like the odds of Spartan Weaponry being updated with the new API for 1.16.5 I 100% expect ObliviousSpartan will go direct to next updates being 1.17, 1.18 or even 1.19 In the meantime I am going to make the changes now that will allow it to be used, it is just hacky because it means Spartan Fire will be supplying textures in the SpartanWeaponry namespace |
|
Damn, I was hoping to just include add the other namespace items under the spartanweaponry namespace within spartanfire but that is breaking everything in spartanweaponry's original namespace, all tooltips, names, everything... So that is a negatory... |
|
The way I see it there are three options:
Broken Items:
|
|
in fact the following objects should be put in the asset models of spartanweaponry, the others should be put in spartanfire. |
1 similar comment
|
in fact the following objects should be put in the asset models of spartanweaponry, the others should be put in spartanfire. |
|
Honestly I just split everything rather than being selective because it was easier to visualise what was outstanding. The ideal situation is it get's updated and they are all in SpartanFire and is really what I am holding out for because it is just too much of a nightmare to have split resources. |
|
Still no update from Oblivious in my issue over on his repository for SpartanWeaponryApi. I wish I had a direct line but I have not been able to find a contact for him anywhere :( |
|
I believe that for the moment there is no other choice. |
|
|
The latest rc-2 update fixes the problem |
|
Scythe Textures :
|
|
Apparently Oblivious has updated Spartan Weaponry, unfortunately I am not playing at the moment so I don't have the infrastructure to test on but I am happy if someone wants to branch off mine and finish this off! 😊 |
1 similar comment
|
Apparently Oblivious has updated Spartan Weaponry, unfortunately I am not playing at the moment so I don't have the infrastructure to test on but I am happy if someone wants to branch off mine and finish this off! 😊 |
Log of changes:
Updated the lightning weapons to call down lightning instead of just doing lightning damage
Updated the model generator Python script and generated all models
Cleaned up a few unnecessary files (including those updated by newer variants or are just no longer required)
Moved the logo file to mod.toml friendly location and updated the Git readme to reference this logo for the title
renamed battlehammer_* textures back to hammer_* after finding out that SpartanWeaponry updated the name but not the resource name
To Do:
Create new Lightning weapon textures
Fix Tooltips, currently the item name and trait is being shown as a resource location
Fix Model generators, currently this is believed to be held back by the IaF bug raised in Issue #4214 in IaF repo
Potentially create Recipe generators, still a little unsure how to do this with items created using SpartanWeaponry API