Add Authorization for Measurement Creation #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyropy
requested review from
bajtos,
juliangruber and
NikolasHaimerl
as code owners
pyropy
changed the title
bajtos
requested changes
Jun 24, 2025
There was a problem hiding this comment.
NOICE!
- Let's fix the TODO item, please - see my comment below.
- I think we need to first ship a new spark-0k-checker version that sets the access token, before we can land & ship this. Correct?
- Can we revert chore: Remove domain redirect #647 and https://github.com/CheckerNetwork/spark-0k-checker/pull/5 now?
api/bin/spark.js
Outdated
Comment on lines
27
to
28
| // TODO: | ||
| assert(CHECKER_TOKEN, 'CHECKER_TOKEN is required') |
There was a problem hiding this comment.
Good catch, I've left TODO to add adittional context why is the CHECKER_TOKEN required.
There was a problem hiding this comment.
I've added a small comment 03b5110. Let me know if you think I should add more context.
Yes, that would be correct.
Indeed we could revert both. I propose that we revert only chore: Remove domain redirect #647 as https://github.com/CheckerNetwork/spark-0k-checker/pull/12 contains changes that will make sure that |
This was referenced Jun 24, 2025
SGTM 👍🏻 |
juliangruber
approved these changes
Jun 24, 2025
Co-authored-by: Julian Gruber <[email protected]>
NikolasHaimerl
approved these changes
Jun 24, 2025
…easurement-submission-authorizaiton
…:CheckerNetwork/spark-api into add/measurement-submission-authorizaiton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new authorization mechanism for the
createMeasurementAPI endpoint by requiring acheckerToken. Additionally, it updates the test suite to validate this new functionality thoroughly. The changes enhance security and ensure unauthorized or invalid requests are properly handled.API Updates:
checkerTokenparameter to thehandlerfunction and updated thecreateMeasurementfunction to check for valid authorization headers before measurement creation. Unauthorized requests now return a403 Unauthorizedresponse. (api/index.js, [1] [2] [3]createHandlerfunction to include thecheckerTokenparameter when initializing thehandler. (api/index.js, api/index.jsL459-R472)Test Suite Enhancements:
VALID_CHECKER_TOKENto test constants and updated all relevant test cases to include theauthorizationheader with the valid token when making POST requests to/measurements. (api/test/test.js, [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]403 Unauthorizedresponse, and no measurements are created in the database. (api/test/test.js, api/test/test.jsR427-R466)checkerTokenare processed successfully, returning the expected responses. (api/test/test.js, api/test/test.jsL642-R680)Related https://github.com/CheckerNetwork/spark-0k-checker/pull/12
Closes #653