serialQueue wasn't actually serial

ChimeHQ · Mar 10, 2020 · d38bb3b · d38bb3b
1 parent 1cf013d
commit d38bb3b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/OperationPlus/Extensions/OperationQueue+Creation.swift b/OperationPlus/Extensions/OperationQueue+Creation.swift
@@ -27,6 +27,6 @@ extension OperationQueue {
     }
 
     public static func serialQueue(named name: String) -> OperationQueue {
-        return OperationQueue(name: name)
+        return OperationQueue(name: name, maxConcurrentOperations: 1)
     }
 }
diff --git a/OperationPlus/OperationPlus.xcconfig b/OperationPlus/OperationPlus.xcconfig
@@ -14,8 +14,8 @@
 PRODUCT_NAME = OperationPlus
 PRODUCT_BUNDLE_IDENTIFIER = com.chimehq.OperationPlus
 PRODUCT_MODULE_NAME = OperationPlus
-CURRENT_PROJECT_VERSION = 8
-MARKETING_VERSION = 1.5.0
+CURRENT_PROJECT_VERSION = 9
+MARKETING_VERSION = 1.5.1
 
 INFOPLIST_FILE = OperationPlus/Info.plist
 

diff --git a/OperationPlusTests/OperationQueueTests.swift b/OperationPlusTests/OperationQueueTests.swift
@@ -11,6 +11,19 @@ import OperationTestingPlus
 @testable import OperationPlus
 
 class OperationQueueTests: XCTestCase {
+    func testSerialCreation() {
+        let queue = OperationQueue.serialQueue()
+
+        XCTAssertEqual(queue.maxConcurrentOperationCount, 1)
+    }
+
+    func testNamedSerialCreation() {
+        let queue = OperationQueue.serialQueue(named: "myqueue")
+
+        XCTAssertEqual(queue.name, "myqueue")
+        XCTAssertEqual(queue.maxConcurrentOperationCount, 1)
+    }
+
     func testDependencies() {
         let opA = Operation()
         let opB = Operation()