split sign method for TonBaseStaker #35
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The
sign
method does a few other things (like wallet creation etc) prior calling thesigner
. If SDK user wants to skip the signer, he/she would have to replicate some of the logic which ain't great.This PR splits the
sign
method into:prepareSigningData
- prepare the final transactionprepareSignerTx
- turns signed TxCell into a SignedTx structureExample without signer abstraction:
Test Plan
https://testnet.tonviewer.com/transaction/58a1db257f9309c587063f9439cbfef8738b6b52fcc2dafa2592e220d7f30996