Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct maximum scroll index within subdirectories #1010

Closed
wants to merge 1 commit into from

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Jan 22, 2025

Type of Change

  • Bug fix

Description

A regression in #933 causes scrolling to be limited to the length of the items, disregarding the parent directory navigation option within subdirectories. This corrects the issue by restoring the previous at_root check.

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2
Copy link
Contributor

Duplicate of #961

@lj3954
Copy link
Contributor Author

lj3954 commented Jan 24, 2025

Correct. Didn't notice that.

@lj3954 lj3954 closed this Jan 24, 2025
@lj3954 lj3954 deleted the fix_scroll branch January 24, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant choose last options inside a folder
2 participants