Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automount disks script, grub bootloader themes script, bottles install script, ssh commands automation #318

Closed
wants to merge 8 commits into from
Closed

automount disks script, grub bootloader themes script, bottles install script, ssh commands automation #318

wants to merge 8 commits into from

Conversation

guruswarupa
Copy link
Contributor

@guruswarupa guruswarupa commented Sep 9, 2024 •
edited
Loading

Pull Request

Title

  • Automount disks script added.
  • grub bootloader theme script added.
  • bottles install script added.
  • few ssh commands automation such as key generation, share key to remote host, disabling password auth, run a command on a remote host, and many more useful commands.

@guruswarupa guruswarupa changed the title automount disks script automount disks script, grub bootloader themes script Sep 9, 2024
@guruswarupa guruswarupa changed the title automount disks script, grub bootloader themes script automount disks script, grub bootloader themes script, bottles install script Sep 9, 2024
@guruswarupa guruswarupa changed the title automount disks script, grub bootloader themes script, bottles install script automount disks script, grub bootloader themes script, bottles install script, ssh commands automation Sep 10, 2024
@nnyyxxxx
Copy link
Contributor

@guruswarupa Too many scripts are being added here; you should move that ssh script to a new PR so this PR is easier to review.

@guruswarupa
Copy link
Contributor Author

guruswarupa commented Sep 11, 2024 •
edited
Loading

@guruswarupa Too many scripts are being added here; you should move that ssh script to a new PR so this PR is easier to review.

@nnyyxxxx only 4 :) not adding anymore to this.

nnyyxxxx
nnyyxxxx reviewed Sep 11, 2024
View reviewed changes
src/commands/utils/ssh.sh Outdated Show resolved Hide resolved
nnyyxxxx
nnyyxxxx reviewed Sep 11, 2024
View reviewed changes
src/commands/utils/ssh.sh Outdated Show resolved Hide resolved
@ChrisTitusTech
Copy link
Owner

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

@guruswarupa guruswarupa reopened this Sep 13, 2024
@guruswarupa
Copy link
Contributor Author

@ChrisTitusTech @nnyyxxxx i've fixed those conflicts.

@nnyyxxxx
Copy link
Contributor

@ChrisTitusTech @nnyyxxxx i've fixed those conflicts.

Awesome!

@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Sep 15, 2024 •
edited
Loading

Can you please split this PR into separate feature PRs

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Sep 18, 2024 •
edited
Loading

Watch out @ChrisTitusTech There are some bashisms in this. read -p is NOT posix compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx left review comments

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guruswarupa @nnyyxxxx @ChrisTitusTech @jeevithakannan2