Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting Testbench panel into a seperate vue component #215

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link
Contributor

Fixes #210

Describe the changes you have made in this PR -

Converting the TestBench code into a separate vue component file.

Screenshots of the changes (If any) -

N/A

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 4bf72e4
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/659ae691a92e2f0008159524
😎 Deploy Preview https://deploy-preview-215--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DhairyaMajmudar
Copy link
Contributor Author

@Prerna-0202 @Arnabdaz pls. review the PR and suggest changes if required

Thank You : )

@DhairyaMajmudar
Copy link
Contributor Author

Hello @Arnabdaz I have kept the testbench component new vue file in src/components/panels

But acc. to folder structure given
image

Do I have to keep the Vue file in the pages folder

pls. clarify

@Arnabdaz
Copy link
Member

we also need to add all the javascript and css related to the testbench not only the html as our target it reducing direct DOM manipulation with js ... look at other components to get the idea

@DhairyaMajmudar
Copy link
Contributor Author

Yes, @Arnabdaz I will soon come up with an updated PR : )

@DhairyaMajmudar DhairyaMajmudar changed the title Converting Testbench panel into a seperate vue componet Converting Testbench panel into a seperate vue component Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Convert Testbench Panel into separate Vue component
2 participants