-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add netlify redirect rule to route root URL to /simulatorvue #448
fix: add netlify redirect rule to route root URL to /simulatorvue #448
Conversation
WalkthroughThe pull request modifies the Netlify configuration file ( Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
netlify.toml (1)
4-8
: Consider optimizing by reducing redirect chain.To improve performance, consider redirecting directly to the final destination:
[[redirects]] from = "/" - to = "/simulatorvue" + to = "/simulatorvue/v0/index-cv.html" status = 301 force = trueThis would eliminate one redirect hop, potentially improving load times slightly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
netlify.toml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
netlify.toml (1)
4-8
: Implementation looks correct but creates a redirect chain.The redirect rule is properly configured with:
- Correct status code (301) for permanent redirect
- Force flag to ensure precedence
- Proper path mapping from "/" to "/simulatorvue"
The redirect will work as intended, creating a chain:
- / → /simulatorvue (301)
- /simulatorvue → /simulatorvue/v0/index-cv.html (200)
Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit