Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIS2-1072] Update linkPlain documentation. #231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amir-clever
Copy link
Contributor

Jira:
https://clever.atlassian.net/browse/DIS2-1072

Overview:
Improve documentation for linkPlain.

Screenshots/GIFs:
image

Testing:

  • [n/a] Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE10

Roll Out:

  • Before merging:
    • Updated docs
    • [n/a] Bumped version in package.json
      • Breaking change? Run npm version minor
      • Backward compatible change? Run npm version patch
      • Only changing documentation? All good. Skip this step.
  • After merging:
    • Deployed updated docs (make deploy-docs)

Copy link
Contributor

@kofi-clever kofi-clever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

the font size of the DOM element they are contained in.
</span>
</p>
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt: could assign the LARGE_FONT_... class here too so it's more obvious that the link button doesn't match the font size around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants