Unvendor react datepicker #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prime-time
force-pushed
the
unvendor-react-datepicker
branch
from
e0dbb99 to
d0d1e0a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
https://clever.atlassian.net/browse/FEE-107
Overview:
Below are the temporary changes we made after discovering a bug with react-datepicker. The bug fix has been merged in react-datepicker, and the code in the vendored directory isn't compatible with React 16, so this is a good opportunity for us to remove the venoring and update the dependencies.
#175
#176
Bug fix to datepicker:
Hacker0x01/react-datepicker#941
Hacker0x01/react-datepicker#825
With this change, I was able to bump up to React 16.2 and run components locally.
Relevant to the quest for React 16:
#274
#275
Testing:
Roll Out:
package.jsonnpm version minornpm version patchmake deploy-docs)