Skip to content

Commit

Permalink
Update README and CHANGELOG, fix test comment
Browse files Browse the repository at this point in the history
  • Loading branch information
slvrtrn committed Apr 2, 2024
1 parent f0e99b4 commit 64b5f81
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ Currently not supported via URL:

See also: [URL configuration example](./examples/url_configuration.ts).

### Performance

- (Node.js only) Improved performance when decoding the entire set of rows with _streamable_ JSON formats (such as `JSONEachRow` or `JSONCompactEachRow`) by calling the `ResultSet.json()` method. NB: The actual streaming performance when consuming the `ResultSet.stream()` hasn't changed. Only the `ResultSet.json()` method used a suboptimal stream processing in some instances, and now `ResultSet.json()` just consumes the same stream transformer provided by the `ResultSet.stream()` method (see [#253](https://github.com/ClickHouse/clickhouse-js/pull/253) for more details).

### Miscellaneous

- Added `http_headers` configuration parameter as a direct replacement for `additional_headers`. Functionally, it is the same, and the change is purely cosmetic, as we'd like to leave an option to implement TCP connection in the future open.
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
<img alt="NPM Downloads" src="https://img.shields.io/npm/dw/%40clickhouse%2Fclient?color=%233178C6&logo=npm">
</a>

<img alt="NPM Type Definitions" src="https://img.shields.io/npm/types/%40clickhouse%2Fclient?color=%233178C6&logo=typescript">

<a href="https://github.com/ClickHouse/clickhouse-js/actions/workflows/tests.yml">
<img src="https://github.com/ClickHouse/clickhouse-js/actions/workflows/tests.yml/badge.svg?branch=main">
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ describe('Node.js socket handling', () => {
const error = (pingResult as ConnPingResult & { success: false }).error
expect((error as NodeJS.ErrnoException).code).toEqual('ECONNREFUSED')
}
// now we start the server, and it is available; and we should have already used every socket in the pool server = http.createServer(async (req, res) => {
// now we start the server, and it is available; and we should have already used every socket in the pool
server = http.createServer(async (req, res) => {
res.write('Ok.')
return res.end()
Expand Down

0 comments on commit 64b5f81

Please sign in to comment.