[Node.js] Fix incomplete rows handling in streaming transformations #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
commented
Oct 16, 2023
slvrtrn
changed the title
mshustov
reviewed
Oct 17, 2023
mshustov
reviewed
Oct 17, 2023
mshustov
approved these changes
Oct 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In specific scenarios, with a large number of incoming rows and/or large chunk sizes, incomplete rows were not handled correctly, and produced corrupted UTF-8 strings.
NB: I still need to check the web version, as I suspect it could have the same bug. See #205
Checklist