Improvements to the Tuple and Map parameter binding #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #358
The client now exports a new wrapper class:
TupleParam
, as tuples need to be serialized as just strings like('foo','bar')
; however, if it is provided like that in the current version, the single quotes will be escaped, which results in a query failure.Added a proper format for the JS
Map
type (it was missing previously), as specifying maps as just objects works only if the CH Map key is a String (cause the JS keys are always strings), and fails in case of Ints, etc.Checklist