Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Foods Actions #193

Open
wants to merge 6 commits into
base: python3.4
Choose a base branch
from

Conversation

techdarko
Copy link

Added rootbeer, beer, and cocktail to the foods subroutine. Root Beer
creates random statement from list like taco. Beer selects a random beer
from the list (pulled from Beer Advocates top 250 beers) and shows beer
name, brewery, ABV, and style. Cocktail selects random cocktail,
displays randomly generated statement with selected cocktai land
includes link to cocktail recipe on webtender wiki.

Added rootbeer, beer, and cocktail to the foods subroutine. Root Beer
creates random statement from list like taco. Beer selects a random beer
from the list (pulled from Beer Advocates top 250 beers) and shows beer
name, brewery, ABV, and style. Cocktail selects random cocktail,
displays randomly generated statement with selected cocktai land
includes link to cocktail recipe on webtender wiki.

if not is_valid(user):
return "I can't give a beer to that user."
if (user == 'tux'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is tux?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops - that's specific for the 2600/telephreak IRC server - tux is a 19 year old op who is lambasted for not being able to drink. Can update & remove if desired.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am tux, pls keep.

@astrutt
Copy link

astrutt commented Mar 15, 2016

Please merge pull request this into main.

@tuxxy
Copy link
Contributor

tuxxy commented Jun 13, 2016

Apparently, the maintainers have left the project for dead and have stopped reviewing pull requests.
If you make a pull request on my fork, I'll go ahead and merge it.

https://github.com/tuxxy/CloudBot

@Red-M
Copy link
Contributor

Red-M commented Jun 14, 2016

This PR may have been overlooked or @lukeroge may have just not been able to pull it if he wanted to.
Simply copy pasting the SAME comment into PRs and not reading about how the version structure works is unacceptable.

PRs that are requested into the master branch are generally ignored as I believe to be that its not meant to be directly PR'ed to that branch until such a time that it is deemed acceptable to do so, mainly by Luke himself.

@tuxxy
Copy link
Contributor

tuxxy commented Jun 14, 2016

Then comment on the PR and say that’s why you’re not pulling it, don’t just ignore it...

On Jun 13, 2016, at 20:34, Red_M [email protected] wrote:

This PR may have been overlooked or @lukeroge https://github.com/lukeroge may have just not been able to pull it if he wanted to.
Simply copy pasting the SAME comment into PRs and not reading about how the version structure works is unacceptable.

PRs that are requested into the master branch are generally ignored as I believe to be that its not meant to be directly PR'ed to that branch until such a time that it is deemed acceptable to do so, mainly by Luke himself.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #193 (comment), or mute the thread https://github.com/notifications/unsubscribe/ADbn7tdyCh4Fh4b18fuxIeq2jIDM8zlpks5qLhMogaJpZM4F-jWE.

@Red-M
Copy link
Contributor

Red-M commented Jun 14, 2016

In the sake of keeping the conversation in one stream please move it to PR #212

@daboross
Copy link
Contributor

Opinions on this?

I can definitely merge, just wondering if the other contributors want to weigh in on if this is in scope of CloudBot.

@Red-M
Copy link
Contributor

Red-M commented Jun 17, 2016

Not sure personally, seems fine to me but i'd wait for luke to say
something with this one.
On 17 Jun 2016 9:33 AM, "Dabo Ross" [email protected] wrote:

Opinions on this?

I can definitely merge, just wondering if the other contributors want to
weigh in on if this is in scope of CloudBot.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#193 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABZoEd6EYk1VdFGwZfUBUYMy2ApxUXQPks5qMd0ygaJpZM4F-jWE
.

@edwardslabs
Copy link
Member

I would say this is probably not in the scope of CloudBot.

linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this pull request Oct 25, 2017
…apper

Fix SyntaxError on 3.7.0a2+ with use of async as a name
linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this pull request Feb 9, 2018
…-func-launches

Refactor hook launching system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants