-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Foods Actions #193
base: python3.4
Are you sure you want to change the base?
Conversation
Added rootbeer, beer, and cocktail to the foods subroutine. Root Beer creates random statement from list like taco. Beer selects a random beer from the list (pulled from Beer Advocates top 250 beers) and shows beer name, brewery, ABV, and style. Cocktail selects random cocktail, displays randomly generated statement with selected cocktai land includes link to cocktail recipe on webtender wiki.
|
||
if not is_valid(user): | ||
return "I can't give a beer to that user." | ||
if (user == 'tux'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is tux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops - that's specific for the 2600/telephreak IRC server - tux is a 19 year old op who is lambasted for not being able to drink. Can update & remove if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am tux, pls keep.
Corrected automatic tabs by IDE.
Conflicts: plugins/foods.py
Please merge pull request this into main. |
Apparently, the maintainers have left the project for dead and have stopped reviewing pull requests. |
This PR may have been overlooked or @lukeroge may have just not been able to pull it if he wanted to. PRs that are requested into the master branch are generally ignored as I believe to be that its not meant to be directly PR'ed to that branch until such a time that it is deemed acceptable to do so, mainly by Luke himself. |
Then comment on the PR and say that’s why you’re not pulling it, don’t just ignore it...
|
In the sake of keeping the conversation in one stream please move it to PR #212 |
Opinions on this? I can definitely merge, just wondering if the other contributors want to weigh in on if this is in scope of CloudBot. |
Not sure personally, seems fine to me but i'd wait for luke to say
|
I would say this is probably not in the scope of CloudBot. |
…apper Fix SyntaxError on 3.7.0a2+ with use of async as a name
…-func-launches Refactor hook launching system
Added rootbeer, beer, and cocktail to the foods subroutine. Root Beer
creates random statement from list like taco. Beer selects a random beer
from the list (pulled from Beer Advocates top 250 beers) and shows beer
name, brewery, ABV, and style. Cocktail selects random cocktail,
displays randomly generated statement with selected cocktai land
includes link to cocktail recipe on webtender wiki.