[FLOC-3767] Container volume support in API client #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -760,15 +801,23 @@ def _parse_configuration_container(self, container_dict): | |||
| :return: ``Container`` instance. | |||
| """ | |||
| return Container( | |||
| node_uuid=UUID(hex=container_dict[u"node_uuid"], version=4), | |||
| node_uuid=UUID(hex=container_dict[u"node_uuid"]), | |||
There was a problem hiding this comment.
This change is not really related to this PR. But setting the version of a UUID only makes sense if we are minting a new UUID from some data. Overriding the version when creating a UUID instance from existing UUID data is asking for trouble.
|
I'm happy w/ the PEP 484 things in docstrings. Thanks! |
added 2 commits
December 31, 2015 12:09
This is not actually required, since removing a PClass attribute will return it to the initial value. It is not possible to really remove a PClass attribute with an initial value. However, following submission of a bug report, there may be changes in the future. Pyrsistent is pre-1.0.
jongiddy
added a commit
that referenced
this pull request
Dec 31, 2015
…LOC-3767 [FLOC-3767] Container volume support in API client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For benchmarking, we still require the container API. However, the
flocker.apiclient.Clientdoes not support volumes attached to containers, which is needed for benchmarking.This PR adds support for stateful containers to the API client, both when creating containers, and when receiving information about container configuration and state.
Note the use of PEP 484 type annotations in the docstrings. Currently we have a variety of patterns for non-primitive docstring types (including
|, top-level type only (dict), verbose descriptions, and leaving them out completely). Despite there being no implementation support for them in Python 2, the PEP 484 type annotations work particularly well for a function like_parse_volumes, where they quickly make apparent the transformation taking place.