Feature：Add prometheus to monitor the gateway and grpc server #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CocaineCong
reviewed
Feb 27, 2024
pkg/prometheus/config/files/.gitkeep
Outdated
There was a problem hiding this comment.
因为git无法追踪文件夹，为了让这个文件夹被追踪以挂载到prometheus容器中，所以创建一个空文件。提前有这个文件夹存在的话也不必在代码中再去检查这个文件夹是否存在，以便于后续的json文件的生成。事实上prometheus是可以以静态文件的方式追踪grpc服务的metrics的，但是为了扩展性，我觉得以文件的动态发现的方式好一点。这样就不用手动的修改prometheus的配置文件从而实现服务的动态发现。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etcd-related methods in discover package are not reused in order to meet customization needs
Even it have a lot of change but most change is from json file，don't worry
See pkg/prometheus/README.md for more datail #53