[Feature]: Privacy Page #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown-0perator
requested review from
CorreyL,
immangat,
nam-m and
SamHuo213
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorreyL
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
I like how you've refactored a bunch of uses of px in code-of-conduct.scss to rem! This seems much more maintainable to me.
Not related to this PR, but I did catch it as I was reviewing the results of this PR, particularly when in a Mobile screen, the desired footer looks like this on the Figma:
But the current design looks like this:
I opened #57 to keep track of this, I may try to pick it up if time permits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54
Figma