[Feature]: Team Dedicated Page #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown-0perator
requested review from
CorreyL,
immangat,
nam-m and
SamHuo213
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CorreyL
requested changes
Sep 23, 2024
There was a problem hiding this comment.
I made sure to load up the Vercel preview deployment too, and it generally looks good to me!
Just one code suggestion, and also wanted to note that I noticed that on Mobile, there are certain areas (see underlined in red) where Padding from an edge (either the edge of the page, or another component) could be improved
src/app/our-team/[team_member_id]/member-dedicated-page-client.test.tsx
Outdated
Show resolved
Hide resolved
….test.tsx Co-authored-by: Correy Lim <[email protected]>
Angle bracket assertion conflicts with TSX files, as noted in the documentation here: https://www.typescriptlang.org/docs/handbook/jsx.html#the-as-operator
CorreyL
reviewed
Sep 25, 2024
| @@ -79,7 +79,7 @@ module.exports = { | |||
| '@typescript-eslint/consistent-indexed-object-style': 'error', | |||
| '@typescript-eslint/consistent-type-assertions': [ | |||
| 'error', | |||
| { assertionStyle: 'angle-bracket', objectLiteralTypeAssertions: 'never' }, | |||
| { assertionStyle: 'as', objectLiteralTypeAssertions: 'never' }, | |||
CorreyL
previously approved these changes
Sep 25, 2024
addressed 4f315eb |
CorreyL
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #58