Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

[WIP] - Dependencies Updated #12

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

[WIP] - Dependencies Updated #12

wants to merge 36 commits into from

Conversation

JamesVanWaza
Copy link

@JamesVanWaza JamesVanWaza commented May 5, 2020

Updated dependencies,

Font Awesome was updated to Version 5

babel/core was removed since you are using @babel/core

@cameronadams777
Copy link
Contributor

@JamesVanWaza Looks like there are some conflicts. Can you please rebase and resolve this issue.

@JamesVanWaza JamesVanWaza changed the title Dependecies Updated Dependencies Updated May 5, 2020
@JamesVanWaza
Copy link
Author

@cameronadams777 Done

@cameronadams777
Copy link
Contributor

@JamesVanWaza I see that you have pushed a few new commits here. Are you just periodically updating until this is merged or are you still actively working on this?

@JamesVanWaza
Copy link
Author

Periodically updating

@cameronadams777
Copy link
Contributor

@JamesVanWaza When trying this out to make sure that nothing was broken before approving and merging, I am receiving this error:
Screen Shot 2020-06-02 at 9 41 06 AM

Are you seeing this as well? And if so, are you checking that the application still builds after updating these modules?

@JamesVanWaza
Copy link
Author

@cameronadams777 yes I got the same error. Still trying to figure that out.

@cameronadams777 cameronadams777 changed the title Dependencies Updated [WIP] - Dependencies Updated Jul 11, 2020
@JamesVanWaza
Copy link
Author

@cameronadams777, any luck, with the version error?

@cameronadams777
Copy link
Contributor

@JamesVanWaza yeah I was able to fix that. There are several issues I'm still working out. The current issue being with the update to Monaco. If you would like, I can push up my changes and let you continue working on it.

@JamesVanWaza
Copy link
Author

That would be good

@JamesVanWaza
Copy link
Author

@cameronadams777 still waiting for pull request

@cameronadams777
Copy link
Contributor

@JamesVanWaza I have updated a few more dependencies, added some dependencies that are needed that since this project was open sources, have been labeled as peer dependencies but there are still some snags I was running into with the css-loaders. That said, I am pretty limited on time these days (I apologize for taking this long to even get this commit in) so can you please take a look?

@JamesVanWaza
Copy link
Author

@cameronadams777 Will check did you send the updated pull request?

@JamesVanWaza
Copy link
Author

Are you getting this error as well?

Screen Shot 2020-09-22 at 10 51 56 AM

Screen Shot 2020-09-22 at 10 54 00 AM

@cameronadams777
Copy link
Contributor

@JamesVanWaza I went ahead and made the change to your fork as it seems that PRs are not available for the repo. That said I am not seeing that error. Maybe try deleting node_modules and yarn.lock and reinstalling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants