Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inverted progressbar movement #534

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Manawyrm
Copy link

@Manawyrm Manawyrm commented Aug 9, 2017

This change adds a new configuration option called "invertProgressBar", which can make the remaining time progress bar slide from left to right.

This change adds a new configuration option called "invertProgressBar", which can make the remaining time progress bar slide from left to right.
@TimFerrell
Copy link
Member

Hi @Manawyrm - this breaks existing tests, and has no tests written for it. If you could resolve those issues, and change the PR to develop then I'd be glad to take a look!

@Manawyrm
Copy link
Author

Hello @TimFerrell
thank you for your time, I have now added a test which checks the default state and running direction of the progress bar.

The failing CI tests doesn't really seem to be caused by me:
The error says something about

/home/travis/build/CodeSeven/toastr/node_modules/gulp-task-listing/node_modules/chalk/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.

which I imagine is an error in a library that is used.
When running the tests manually, they all go through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants