Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtask 73: setting base typeface #113

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

yenhtran
Copy link

@yenhtran yenhtran commented Feb 6, 2024

Description:

  • UI/UX wanted specific typeface
  • Font typeface between popover/driver and legend are different

Proposed fix:
Looks like PR #79 proposed a solution but their fix was never merged in. This PR incorporates their fix but also specifically applies the font typeface to the driver as well.

Before
Screenshot 2024-02-04 at 3 21 36 PM
Screenshot 2024-02-04 at 3 14 06 PM

After
Screenshot 2024-02-04 at 3 21 10 PM
Screenshot 2024-02-04 at 3 16 48 PM

@yenhtran yenhtran requested a review from a team as a code owner February 6, 2024 04:43
@tyliec tyliec requested a review from kmal808 February 6, 2024 08:28
@tyliec tyliec linked an issue Feb 6, 2024 that may be closed by this pull request
@@ -105,6 +114,12 @@ hr {
max-width: 450px !important;
}

#driver-popover-item * {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened this issue to eventually clean this up, once we get off of our older version of driver.js. Related: https://driverjs.com/docs/styling-popover

Copy link
Member

@kmal808 kmal808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢
Bonus points for the screenshots 👏

@kmal808
Copy link
Member

kmal808 commented Feb 6, 2024

Preview @ https://hza-pr-113.wtf.kim

@yenhtran yenhtran merged commit 26a190d into main Feb 6, 2024
@yenhtran yenhtran deleted the subtsk-73-setting-base-typeface branch February 6, 2024 17:36
@yenhtran yenhtran mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtask: 📃 Setting base typeface
3 participants