Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup instructions and cleanup #78

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Conversation

tyliec
Copy link
Member

@tyliec tyliec commented Mar 17, 2024

Description

This PR contains an initial working UIPA.org froide theme, along with instructions contained in the README to get it working.

Some things have been deleted that we will eventually need to place back (i.e. a Test and a Prod environment settings file). Other things have been left in a disintegrated state (many uipa_org.theme Python modules), however this at least will provide a working baseline for future development.

Much of this PR (requirements.txt versions and settings/ folder structure) were taken from https://github.com/okfde/fragdenstaat_de/tree/main/fragdenstaat_de. For things that were removed from the codebase in this PR, they can still be referenced in the master branch in this repository.

Related Items

Relevant Issue: #50

@tyliec tyliec requested a review from russtoku March 17, 2024 11:25
uipa_org/settings/base.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
russtoku
russtoku previously approved these changes Mar 17, 2024
Copy link
Member

@russtoku russtoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the Getting Started section several times on my Macbook Air trying to see where a new person would get tripped up. I have a lot more suggestions but for the immediate need, let's call it good to go and move on. I can make a PR for other changes later.

Please correct the requirements.txt before merging this PR because it could be a blocker for a new person.

The suggestions for the README and upia_org/settings/base.py can be ignored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

  • It may be better to put the Getting Started section in a separate document so that this page isn't too long to read. Replace it in the README with a link called Getting Started for Developers. The document could be called Developers because it is for people wanting to run the website locally or help make changes. May be developers isn't the best term to use.
  • Put the Frontend section before the Backend because the next step would be to visit the home page of the website that the backend is serving. The frontend can be started up before the backend.
  • There should be some short explanation of what the frontend providing, why it is needed, and how a developer would make changes to the frontend portion. For deployment, would the frontend be needed? I guess that should be covered in a Deployment document.
  • Later, it might be clearer to separate the steps that are done as initial setup from the step that runs the frontend and the backend servers in their respective sections. The current wording tries to help with these two different situations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this indicates we should do another run at cleaning up the Wiki - maybe just adding another page to the Wiki with the entire "Getting Started" section

requirements.txt Outdated Show resolved Hide resolved
@russtoku
Copy link
Member

I forgot to mention that the drop-down menu for Hello doesn't work when you visit the home page at http://localhost:8000/ or http://127.0.0.1:8000/.

Interestingly, the font size is different between what the two URLs render.

@tyliec tyliec merged commit 0e984ac into main Mar 18, 2024
@tyliec tyliec deleted the tyliec/initial-setup-v2 branch March 18, 2024 00:41
@tyliec tyliec mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants