-
-
Notifications
You must be signed in to change notification settings - Fork 620
NW6 | AREEB-SATTAR | HTML-CSS | MODULE-PROJECT | WEEK-1 #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I love what I see here Areeb. You've demonstrated a great range of HTML/CSS super powers, with advanced CSS selectors and excellent semantic HTML. I particularly like how you use a nested flexbox for the Karma icons on the homepage. And your order form looks great, they are notoriously difficult to style - made even better by using HTML5 validations such as Just a few pointers from me:
To help your uncertainty on when to use absolute/relative units: I can't give any solid answers, but as a rule of thumb I would prefer relative units wherever possible. This helps to make the site as responsive as possible. You need to be disciplined (lots of nested relative units can get confusing), but on the whole you can use relative units to make sizes that scale beautifully, whether that is based on the screen size or the user's preferred font size. |
Thank you for the feedback Jay, I will keep these pointers in mind for future |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.md
in the root of this repositoryYour Details
Homework Details
Notes
Writing some of the HTML,
Found writing semantic HTML a bit tough and styling few things
When is it best to use relative and absolute values
N/a