Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF London | Fatma Arslantas | Module-Data-Flows | Week 2 | Book Library #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AFatmaa
Copy link

@AFatmaa AFatmaa commented Dec 30, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@AFatmaa AFatmaa added the Needs Review Participant to add when requesting review label Dec 30, 2024
@tyzia tyzia added Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Dec 31, 2024
@tyzia
Copy link

tyzia commented Dec 31, 2024

I like the effort you put into your work! Very verbose. It is great for learning assignments, but please, keep in mind that in production code it is recommended to keep comments to minimum. Keep up good work!

@AFatmaa
Copy link
Author

AFatmaa commented Dec 31, 2024

Hi @tyzia,

Thank you so much for the kind feedback and for taking the time to review my code! 😊
You’re absolutely right, and I completely understand your point. I added those extra comments mainly for myself to better understand the code and logic during the process. I’ll definitely keep this in mind moving forward.

Thanks again for your guidance and support! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants