Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London | Gislaine Della Bella | Module-Data-Flows | Week 2 | DEBUGGING BOOK LIBRARY #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Della-Bella
Copy link

Learners, PR Template

Self checklist

  • [X ] I have committed my files one by one, on purpose, and for a reason
  • [X ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [X ] I have tested my changes
  • [X ] My changes follow the style guide
  • [X ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Hi volunteer,
Thank you for look at my code,
Gislaine

@Della-Bella Della-Bella added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jan 1, 2025
@halilibrahimcelik halilibrahimcelik self-requested a review January 2, 2025 19:11
@halilibrahimcelik halilibrahimcelik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jan 2, 2025
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work, everything is working as expected! Here are some points that you might have to consider if you want to enhance submit form. While submitting books, if user only uses white spaces, it passes your if check.
Also you can also check input values of page field for instance. It is an unlike scenario but what if user write negative numbers. you can also prevent this within submit function
image

readStatus = "No";
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to increase UI&UX experience, you can also change color of "NO" btn to red color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants