Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

London| Phone_Naing | Module_Data_Flows|Book_Library|Sprint2 #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London| Phone_Naing | Module_Data_Flows|Book_Library|Sprint2 #121

wants to merge 1 commit into from

Conversation

Mgphone
Copy link

@Mgphone Mgphone commented Jan 5, 2025

Learners, PR Template

Self checklist

  • [ X] I have committed my files one by one, on purpose, and for a reason
  • [X ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ X] I have tested my changes
  • [X ] My changes follow the style guide
  • [X ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Mgphone Mgphone added the Needs Review Participant to add when requesting review label Jan 5, 2025
@Mgphone Mgphone changed the title London| Phone_Naing | Module_Data_Flows|Book_Library London| Phone_Naing | Module_Data_Flows|Book_Library|Sprint2 Jan 5, 2025
@tyzia tyzia added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 5, 2025
tyzia
tyzia reviewed Jan 5, 2025
View reviewed changes
Copy link

@tyzia tyzia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyzia tyzia tyzia left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mgphone @tyzia