Manchester | Zabihollah Namazi | Module-Data-Flows | Challenges | unit-testing | katas-tdd #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyzia
added
Review in progress
tyzia
reviewed
Jan 5, 2025
| } | ||
| } | ||
|
|
||
| return sum; |
There was a problem hiding this comment.
Overall looks good. Please, mind code formatting and spacing:
Bad:
){
if(
else{
=listNumber
Good:
) {
if {
else {
= listNumber
tyzia
reviewed
Jan 5, 2025
| } | ||
|
|
||
| myData = await response.json() | ||
| //console.log(`${JSON.stringify(myData)} this is api`) |
There was a problem hiding this comment.
Please, remove commented out code from your final work.
tyzia
reviewed
Jan 5, 2025
| throw new Error(`HTTP error! Status: ${response.status}`); | ||
| } | ||
|
|
||
| myData = await response.json() |
There was a problem hiding this comment.
Don't forget to add ; at the end of your expressions. JS allows to omit them, but this can lead to unexpected errors/results.
tyzia
added
Reviewed
ZabihollahNamazi
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.