Skip to content

ITP London - Jan 2025 | Samunta Sunuwar| Module Data Flows | Book Library #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ITP London - Jan 2025 | Samunta Sunuwar| Module Data Flows | Book Library #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93dff77
Index Html
Samunta Apr 16, 2025
1470a9f
Script.Js
Samunta Apr 16, 2025
c1fd26d
Fixing errors according to https://validator.w3.org/. (In HTML5, the …
Samunta Apr 19, 2025
19208f1
Refactoring my logic for input validation, removed .value to be null …
Samunta Apr 19, 2025
18ade97
Refactoring my render function by adding innerHTML = "" to wipe all r…
Samunta Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 21 additions & 26 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<!DOCTYPE html>
<html>
<html lang="en"> <!-- Adding lang attribute for accessibility and validation -->
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<!-- Correcting meta placement and fixing tag issues -->
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- Adding an appropriate title -->
<title>Sam's Book Library</title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<!-- Removing trailing slash from link tags -->
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
>
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -30,43 +29,45 @@ <h1>Library</h1>
<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<!-- fixing type from title to text -->
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<!-- fixing type from author to text -->
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</div>

Expand All @@ -81,13 +82,7 @@ <h1>Library</h1>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<!-- removing empty <tr> to prevent blank row on page load -->
</tbody>
</table>

Expand Down
96 changes: 45 additions & 51 deletions debugging/book-library/script.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Line 76:

    • The current method of assigning book titles to HTML elements can cause display issues if a title contains special character sequences like <i>.

  • Can you suggest a more consistent naming convention for the variables representing the two buttons, currently named changeBut and delButton?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, I have made changes as requested.

Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,32 @@ const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
// Trimming white spaces in values and validating user input
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
title.value.trim() === "" ||
author.value.trim() === "" ||
pages.value.trim() === ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
//Adding validation to check pages is a positive whole number
const pagesValue = Number(pages.value);
if (!Number.isInteger(pagesValue) || pagesValue <= 0) {
alert("Please enter a valid number for pages.");
return false;
}

// GPT: Create and add new Book
let book = new Book(
title.value.trim(),
author.value.trim(),
pagesValue,
check.checked
);
myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +61,37 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tableBody = document.querySelector("#display tbody");
tableBody.innerHTML = "";
myLibrary.forEach((book, i) => {
const row = tableBody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

changeBut.addEventListener("click", function () {
const readButton = document.createElement("button");
readButton.className = "btn btn-success";
readButton.textContent = book.check ? "Yes" : "No";
readButton.addEventListener("click", () => {
myLibrary[i].check = !myLibrary[i].check;
render();
});
wasReadCell.appendChild(readButton);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", () => {
alert(`You've deleted title: ${book.title}`);
myLibrary.splice(i, 1);
render();
});
}
}
deleteCell.appendChild(deleteButton);
});
}