LONDON_JAN25 | KHALIL ALI | MODULE_DATA_FLOWS | SPRINT 2 | BOOK_LIBRARY

[khalil-ali1]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Fix all book library project bugs.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?

I also suggested some improvements for you to consider.

[cjyuan]

Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?

[cjyuan]

• In terms of input validation,

  1. Are all input properly checked?
  2. Can .value be null? (Do we need to check someInputElement.value == null?)
  3. Do you want to allow book title and author name to contain only space characters?
  4. What if a user enters an invalid page number in the "pages" input field?

• Lines 75, 93:

  • Are the values assigned to these id attributes unique?
  • Is there any need to assign an id attribute to either buttons?

• Line 69:

  • The current method of assigning book titles to HTML elements can cause display issues if a title contains special character sequences like <i>.

[khalil-ali1]

• i. I have checked all input properly
• ii. .value can not be null.
• iii. .trim() deletes all spaces
• iv. the "pages" input should not be empty and should be a positive integer

id attributes are not unique
There is no need to assign id attributes to either buttons

you are right. I used textContent instead of innerhtml

[khalil-ali1]

I used https://validator.w3.org/ to check my HTML file.
I fixed the code and got the "No errors or warnings to show" message.