Sheffield | ITP2025 | Yousef | Wireframe #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: R7Yos <[email protected]>
Signed-off-by: R7Yos <[email protected]>
Signed-off-by: R7Yos <[email protected]>
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cjyuan
reviewed
May 11, 2025
There was a problem hiding this comment.
- Can you change the followings so that your page layout can better match the wireframe layout:
- The left edge of the first article should align with the left edge of the second article, and the right edge should align with the right edge of the third article.
- The child elements of each article are left aligned (not centered) in the wireframe.
- Can you give a brief description to your PR?
- Regarding the PR title:
- The cohort name in the title should be "May-2025".
| <article id="readme"> | ||
| <img src="README.FILE.png" alt="README File Image"> | ||
| <div class="content"> | ||
| <h2>README.FILE</h2> |
There was a problem hiding this comment.
"README.FILE" would suggest you are referring to a file named exactly "README.FILE". "README File" would probably be more appropriate.
There was a problem hiding this comment.
There are some errors in your HTML code.
It's a good practice to use an HTML validator to check our HTML code for errors and ensure it follows web standards.
Can you ensure your code is free of errors?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.