-
-
Notifications
You must be signed in to change notification settings - Fork 267
Sheffield | May-2025 | Yousef | Wireframe #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: R7Yos <[email protected]>
Signed-off-by: R7Yos <[email protected]>
Signed-off-by: R7Yos <[email protected]>
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you change the followings so that your page layout can better match the wireframe layout:
- The left edge of the first article should align with the left edge of the second article, and the right edge should align with the right edge of the third article.
- The child elements of each article are left aligned (not centered) in the wireframe.
- Can you give a brief description to your PR?
- Regarding the PR title:
- The cohort name in the title should be "May-2025".
<article id="readme"> | ||
<img src="README.FILE.png" alt="README File Image"> | ||
<div class="content"> | ||
<h2>README.FILE</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"README.FILE" would suggest you are referring to a file named exactly "README.FILE". "README File" would probably be more appropriate.
Signed-off-by: R7Yos <[email protected]>
Signed-off-by: R7Yos <[email protected]>
The changes look good. I just noticed something that could use some improvement:
Note: In addition to implementing changes based on reviewer feedback, it's good practice to respond to each comment, indicating what was changed or how the request was addressed. |
- Fixed footer to bottom of viewport - Added border and hover effect to "Read more" summary elements - Styled footer links for better appearance Signed-off-by: R7Yos <[email protected]>
Why do you close this PR? |
By mistake
…On Fri, 16 May 2025 at 17:15, CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#421)
<#421 (comment)>
Why do you close this PR?
—
Reply to this email directly, view it on GitHub
<#421 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLDNLFQ44KTPIY2Q5GICWF326YFKTAVCNFSM6AAAAAB43HNC76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBXGE2TKMBYGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Changes look good! Well done. |
Learners, PR Template
Self checklist
Changelist
.hero
section inside<main>
for structural consistencyflexbox
layout to the second and third articles using.flex-container
text-align: left
)Questions
I don't understand your comment "I think this should be "README File".".
Could you explain more please.