Skip to content

London | May-2025 | Mo Muchunu | Wireframe To Web Code #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

London | May-2025 | Mo Muchunu | Wireframe To Web Code #427

wants to merge 16 commits into from

Conversation

Mo-Muchunu
Copy link

@Mo-Muchunu Mo-Muchunu commented May 11, 2025 •
edited
Loading

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK * [x] I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Structured the webpage using semantic HTML tags and created three unique articles with titles, summaries, and links.

  • Matched webpage layout to the wireframe design and aligned all elements accordingly.

  • Added page title and description; fixed footer to bottom of the viewport.

  • Styled the webpage using an external CSS file and improved layout, image placement, and overall design.

  • Added meta and alt descriptions to improve accessibility.

  • Improved layout, image positioning, and CSS styling to match brief Wireframe.

  • Updated and fixed footer content and alignment.

@netlify Netlify
Copy link

netlify bot commented May 11, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b9b9ecc
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6828a67b9dde3b0008102bc9
😎 Deploy Preview https://deploy-preview-427--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mo-Muchunu Mo-Muchunu added the Needs Review Participant to add when requesting review label May 11, 2025
@Mo-Muchunu Mo-Muchunu changed the title London | May-2025 | Mo Muchunu | Module-Onboarding - Wireframe To Web Code London | May-2025 | Mo Muchunu | Wireframe To Web Code May 11, 2025
@Mo-Muchunu Mo-Muchunu marked this pull request as draft May 14, 2025 11:51
@Mo-Muchunu Mo-Muchunu marked this pull request as ready for review May 14, 2025 13:48
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels May 18, 2025
@cjyuan
Copy link
Contributor

cjyuan commented May 18, 2025

In Markdown syntax, a > character at the start of a line is used to indicate a blockquote.
Any reason you make the content in your PR description block quotes?

image

cjyuan
cjyuan reviewed May 18, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error-free and well-indented.
Implementation of the webpage meets all requirements.
Excellent job.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 18, 2025
@Mo-Muchunu
Copy link
Author

In Markdown syntax, a > character at the start of a line is used to indicate a blockquote. Any reason you make the content in your PR description block quotes?

image

Hi @cjyuan, hadn't figured out how to check boxes so lost template and had to copy/paste back in- I've fixed that now.

@Mo-Muchunu
Copy link
Author

Code is error-free and well-indented. Implementation of the webpage meets all requirements. Excellent job.

Thank you @cjyuan for your feedback- much appreciated!

@Mo-Muchunu Mo-Muchunu mentioned this pull request May 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mo-Muchunu @cjyuan