London | May_2025 | Payman Issa Baiglu | Form-control #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited the name at the end.
…oarding into Form-Control
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Implementation of the form looks good.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Can you improve the indentation of the code?
-
To follow best practices, can you check the items in the Self-Checklist in the PR description to confirm your pull request meets the guidelines?
cjyuan
added
Reviewed
PaymanIB
added
Needs Review
|
Many thanks @cjyuan for reviewing my code. Errors are fixed and indentation of the code is improved. can you please see if it is acceptable. |
|
Changes look good. Well done. |
cjyuan
added
Complete
|
Great, thank you for checking it and the positive feedback.
…On Tue, 3 Jun 2025, 20:23 CJ Yuan, ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#679)
<#679 (comment)>
Changes look good. Well done.
—
Reply to this email directly, view it on GitHub
<#679 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDH7UPDJNTRGYDKDTL7ZST3BXY23AVCNFSM6AAAAAB6NNNFO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZWHA2DANBWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Created a form based on the requested list.
Only used HTML and no CSS codes. checked with lighthouse and Accessibility score is 100.
Questions
Ask any questions you have for your reviewer.