Skip to content

London| May-2025 | Birhan Mesfen | Form-controls #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Birhan-lab
Copy link

@Birhan-lab Birhan-lab commented Jun 3, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2b06dfd
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/683f4e97e2860300087f17a2
😎 Deploy Preview https://deploy-preview-687--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Birhan-lab Birhan-lab added the Needs Review Participant to add when requesting review label Jun 3, 2025
</footer>
</body>
</html>
</header>
Copy link

@eediallo eediallo Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the right html document structure ? You can find more info here: https://www.w3schools.com/html/html_intro.asp

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update it can you check it for me please?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eediallo eediallo added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 3, 2025
@eediallo eediallo added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants