Skip to content

ITP-JUNE-04|Haninabd|ONBOARDING|SPRINT 1 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

haninabd
Copy link

@haninabd haninabd commented Jun 4, 2025

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I am opening this PR to preview my website because I don't have local file access.
I will mark this PR as need review when it ready for review.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c375c21
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6840ca0e7639260008dd7b62
😎 Deploy Preview https://deploy-preview-697--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 91 (🔴 down 9 from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@haninabd haninabd added the Needs Review Participant to add when requesting review label Jun 4, 2025
@cjyuan cjyuan added the 👀 Review Git Changes requested to do with Git label Jun 5, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 5, 2025

  1. You need to prepare your solution for the "Wireframe" and "Form-Controls" exercises in two separate branches so that you can submit two separate pull requests from the branches. (You may want to apply this after you fix your repository, see the next item)

  2. You should not have modified the main branch because it will "pollute" future branches created from main. In all ITP modules, the main branch is expected to be kept unmodified, and all change should only be done in branches created from main.

    • If you know how to undo (reset) the commits you made on your main branch, then you should undo them.
    • Otherwise, it is easier to backup work, delete this repository, and then fork a new "module-onboarding" repo from CYF.
  3. There are some errors in the HTML code. Please fix them.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants