Skip to content

Sheffield | 3 May-2025 | Xiayidan Abuduxukuer | Wireframe #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Shayida999
Copy link

Sheffield | 3 May-2025 | Xiayidan Abuduxukuer | Wireframe

Learners, PR Template

✅ Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

📝 Changelist

  • Completed the Wireframe task from the Form Controls module
  • Added index.html, style.css, and assets like images and placeholder SVG
  • Designed layout with 3 articles, responsive for mobile and desktop

❓ Questions

No questions at the moment — but happy to receive feedback!

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2738289
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6841f1ab18eef8000804545c
😎 Deploy Preview https://deploy-preview-702--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@cjyuan
Copy link
Contributor

cjyuan commented Jun 5, 2025

You were supposed to implement the Wireframe by modifying index.html and style.css in the "Wireframe" folder.

Please transfer your code to those two files and then delete the folder wireframe-task in "Form-Controls".

@cjyuan
Copy link
Contributor

cjyuan commented Jun 5, 2025

Also, you need to add "Needs review" label to your PR to indicate that it is ready to be reviewed.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review label Jun 5, 2025
@Shayida999 Shayida999 added the Needs Review Participant to add when requesting review label Jun 5, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 5, 2025

Code is error-free, well-indented. Implementation is solid too. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants