Glasgow|May-2025|Indira Muniappan|Wireframe review 0900

[ind222]

Glasgow | May -2025| Indira Muniappan | Wireframe

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Change list

Used semantic HTML tags:
ncluded three articles, each with a title, summary, link, and placeholder SVG image.

Styled layout using CSS Grid and custom properties for consistent spacing and responsiveness.

First article spans full width; footer is fixed at the bottom of the page.

Code passes W3C validation with no errors or warnings.

Achieved 100% Accessibility score in Lighthouse.

Ask any questions you have for your reviewer.
No Thank you.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	fce0110
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6842a3e90bbaa60008570637
😎 Deploy Preview	https://deploy-preview-709--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 95 (🟢 up 9 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[ind222]

Hi CJYuan,
I've completed the wireframe task and submitted the PR.
The page follows the design with semantic HTML, CSS Grid layout, placeholder images, and a fixed footer.
It passes W3C validation with no issues and scores 100% on accessibility in Lighthouse.

kindly let me know if any changes are needed for completion my PR.
Warm regards,
Indira.

[cjyuan]

@ind222 Why do you submit another Wireframe PR when you already have a reviewed Wireframe PR #708?

You can continue making change and push your change on the same PR branch.

Please close one of the PRs.

[ind222]

Hi CJ,
I have closed all old PR .

[ind222]

Hi,
My bad ,I didn't know that i can create PR that already reviewed..

[cjyuan]

@ind222 You can't and do not need to recreate a PR that already existed.

When you commit new changes and push the commits to this PR branch, Wireframe_review_0900, this PR will be updated automatically (because it refers to the same branch).

[cjyuan]

You fixed the HTML errors and improved your implementation. Good job!

1. In the PR description, can you check the checkboxes in the Self-checklist to confirm your pull request meets the guidelines?

2. Can you revert the change made to Form-Controls/index.html in the following way?

   • Download Form-Controls/index.html from your main branch (https://github.com/ind222/Module-Onboarding/blob/main/Form-Controls/index.html)
   • Use the downloaded file to replace the version you have in the current branch (Wireframe_review_0900).
   • Commit the change and then push the commits to GitHub.

[ind222]

Hi CJYuan,
When i have tried commit the change and then push the commits to GitHub it says nothing commit.
I am not sure how to do it push commit successfully to Github. Kindly help me to complete my PR request before Step1 Module submission running out.

Warm regards,
Indira

[ind222]

Hi CJYuan,

ITP submission time has been extended ,so i continue work on revert the change made to Form-Controls/index.html and commit the change and then push the commits to GitHub.
I received following results :

On branch feature/wireframe
nothing to commit, working tree clean
(base) laxra@Laxs-MacBook-Pro Module-Onboarding % curl -o Form-Controls/index.html https://raw.githubusercontent.com/ind222/Module-Onboarding/main/Form-Controls/index.html

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 701 100 701 0 0 1513 0 --:--:-- --:--:-- --:--:-- 1514
(base) laxra@Laxs-MacBook-Pro Module-Onboarding % git add Form-Controls/index.html

(base) laxra@Laxs-MacBook-Pro Module-Onboarding % git commit -m "Revert Form-Controls/index.html to match main branch"

On branch feature/wireframe
nothing to commit, working tree clean
(base) laxra@Laxs-MacBook-Pro Module-Onboarding % git push origin feature/wireframe

Everything up-to-date
(base) laxra@Laxs-MacBook-Pro Module-Onboarding %

kindly help me for my successfully completion of this PR.
Warm regards,
Indira.

[cjyuan]

Can you address at least issue 1? Issue 2 is optional for this PR.

What about this request:

1. In the PR description, can you check the checkboxes in the Self-checklist to confirm your pull request meets the guidelines?

(I checked one of the boxes)

2. After you commit changes on your computer, you need to push the commits to GitHub.
   If can cannot resolve this issue in this PR, please find out (with the help of a volunteer) why you cannot push your commits to GitHub, or else you will likely face the same problems in future PRs.

[ind222]

Hi CJYuan,
Thank you for explaining importance to know of commit changes need push to Github.
I have fixed check boxes on the PR Description.
Thank you very much for your incredible support.