Skip to content

WM | ITP-May-2025 | Tesfalem Hailu| Form control #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

tesfathefture
Copy link

@tesfathefture tesfathefture commented Jun 8, 2025

added all labels and widgets

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Revised the content of index.html to improve clarity, structure, and presentation across the homepage. Updates include rewriting text for better readability, organizing sections more effectively, and ensuring that all information is accurate and relevant to the website’s purpose.

Questions

Ask any questions you have for your reviewer.

added all labels and widgets
Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 899871b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/684aca6cb1497800082c21d7
😎 Deploy Preview https://deploy-preview-723--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (🟢 up 3 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@tesfathefture
Copy link
Author

i have no device so i couldnt commit with in the time.

@tesfathefture tesfathefture added the Needs Review Participant to add when requesting review label Jun 11, 2025
@tesfathefture tesfathefture requested review from jenny-alexander, KudahShambare and shieldo and removed request for KudahShambare June 11, 2025 13:25
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error-free and well-indented. Good job!

  1. Could you improve the Lighthouse Accessibility score (as reported by the browser's Lighthouse dev tool) to 100?

  2. Could you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
    image
    (With proper Markdown syntax, we can use mouse to check/uncheck the items)

  3. Could you also address the inline comments I left with the code?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 12, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 12, 2025

Good job in addressing all issues.

  1. According to https://validator.w3.org/, there are errors in your code. Can you fix them?

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback (which you have done for some of the comments, great!)
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

Also, can you find out from ChatGPT the following?

  • What's the best practice to respond to reviewer reviews in a pull request?

You can practice them in future PRs.

@tesfathefture
Copy link
Author

Good job in addressing all issues.

  1. According to https://validator.w3.org/, there are errors in your code. Can you fix them?

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback (which you have done for some of the comments, great!)

    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label

    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

Also, can you find out from ChatGPT the following?

  • What's the best practice to respond to reviewer reviews in a pull request?

You can practice them in future PRs.

@tesfathefture
Copy link
Author

the error in the code are fixed according https://validator.w3.org/.

@tesfathefture tesfathefture added the Needs Review Participant to add when requesting review label Jun 12, 2025
@tesfathefture tesfathefture reopened this Jun 12, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 12, 2025

Errors are all gone, but now I can submit the form without filling any input. Can you address this issue.

@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Jun 12, 2025
@tesfathefture
Copy link
Author

issue is addresed and rectify

@tesfathefture tesfathefture added the Needs Review Participant to add when requesting review label Jun 12, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 12, 2025

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants