-
-
Notifications
You must be signed in to change notification settings - Fork 267
WM | ITP-May-2025 | Tesfalem Hailu| Form control #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WM | ITP-May-2025 | Tesfalem Hailu| Form control #723
Conversation
added all labels and widgets
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
i have no device so i couldnt commit with in the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is error-free and well-indented. Good job!
-
Could you improve the Lighthouse Accessibility score (as reported by the browser's Lighthouse dev tool) to 100?
-
Could you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
(With proper Markdown syntax, we can use mouse to check/uncheck the items) -
Could you also address the inline comments I left with the code?
Good job in addressing all issues.
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
Also, can you find out from ChatGPT the following?
You can practice them in future PRs. |
|
the error in the code are fixed according https://validator.w3.org/. |
Errors are all gone, but now I can submit the form without filling any input. Can you address this issue. |
issue is addresed and rectify |
Changes look good. |
added all labels and widgets
Learners, PR Template
Self checklist
Changelist
Revised the content of index.html to improve clarity, structure, and presentation across the homepage. Updates include rewriting text for better readability, organizing sections more effectively, and ensuring that all information is accurate and relevant to the website’s purpose.
Questions
Ask any questions you have for your reviewer.