PAWEL BROILO I MODULE ONBOARDING I WIREFRAME #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PawelBroilo
changed the title
lawkunchi
added
Review in progress
|
@PawelBroilo You almost close |
lawkunchi
added
Reviewed
|
Hi lawkunchi,
I am happy you have reviewed my Pull Request #724.
I will fix the footer to move along with a Viewport. Thank you
…On Mon, 9 Jun 2025, 07:10 Lawrence Chibondo, ***@***.***> wrote:
*lawkunchi* left a comment (CodeYourFuture/Module-Onboarding#724)
<#724 (comment)>
@PawelBroilo <https://github.com/PawelBroilo> You almost close
You just need to fix the footer to the bottom
—
Reply to this email directly, view it on GitHub
<#724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVFFPRTIV5TR6EFRBQDLGFL3CUQMZAVCNFSM6AAAAAB63OQI3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJUG42TCNBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi Lawrence,
I am happy you have reviewed my Pull Request #724.
I will fix the footer to move along with a Viewport. Thank you
…On Mon, 9 Jun 2025, 08:39 Pawel Broilo, ***@***.***> wrote:
Hi lawkunchi,
I am happy you have reviewed my Pull Request #724.
I will fix the footer to move along with a Viewport. Thank you
On Mon, 9 Jun 2025, 07:10 Lawrence Chibondo, ***@***.***>
wrote:
> *lawkunchi* left a comment (CodeYourFuture/Module-Onboarding#724)
> <#724 (comment)>
>
> @PawelBroilo <https://github.com/PawelBroilo> You almost close
> You just need to fix the footer to the bottom
>
> —
> Reply to this email directly, view it on GitHub
> <#724 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AVFFPRTIV5TR6EFRBQDLGFL3CUQMZAVCNFSM6AAAAAB63OQI3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJUG42TCNBYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hi lawkunchi, |
|
@PawelBroilo You may want to look up what "Viewport" mean. Your footer is not yet fixed at the bottom of the viewport. |
|
Hi CJ,
I will look at Viewport definition. I will adjust a footer to make it fixed
at bottom of the viewport now,
…On Mon, 9 Jun 2025 at 13:22, CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#724)
<#724 (comment)>
@PawelBroilo <https://github.com/PawelBroilo> You may want to look up
what "Viewport" mean. Your footer is not yet fixed at the bottom of the
viewport.
—
Reply to this email directly, view it on GitHub
<#724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVFFPRR7H3PNMJXNP2R36QT3CV3U7AVCNFSM6AAAAAB63OQI3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJVGYZTAMZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi CJ, |
|
|
@lawkunchi I am stepping in because I have been following the PRs of @PawelBroilo. I asked him to create a new PR for his Wireframe exercise because his PR branch was not prepared properly. |
|
Hi CJ,
I think its wiser to submit Wireframe Project submission in Class on
Saturday with a Mentor who can explain my mistake in sending project
itself. My Wireframe Project is correct only a Footer needs to be fixed to
bottom. I modified it with Chat GPT and its still not fixed to bottom of
Viewport. I will submit my Wireframe Project on Saturday in Class with a
Mentor just like Form Controls Project. I will learn Git Hub and Git until
then. Thank you
…On Mon, 9 Jun 2025, 14:43 CJ Yuan, ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#724)
<#724 (comment)>
@lawkunchi <https://github.com/lawkunchi> I am stepping in because I have
been following the PRs of @PawelBroilo <https://github.com/PawelBroilo>.
I asked him to create a new PR for his Wireframe exercise because his PR
branch was not prepared properly.
—
Reply to this email directly, view it on GitHub
<#724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVFFPRW7ILQKHRTJADSA7O33CWFO3AVCNFSM6AAAAAB63OQI3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJVHAZTKNJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Wireframe written in semantic HMTL code and CSS. Wireframe contains articles.
Questions
Ask any questions you have for your reviewer.