London | May-2025 | Gideon Defar | form control #729
+76
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Why submitted another Form-Controls PR when you have already completed the PR in #726? |
cjyuan
added
Reviewed
|
I don't know why the PR is closed. When I tried to reopen it. It says this
pull request is deleted. I renamed the branch name on the vs code and
pushed it to the original but doesn't change the GitHub PR old name.
…On Sat, Jun 14, 2025, 4:31 PM CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#729)
<#729 (comment)>
Why submitted another Form-Controls PR when you have already completed the
PR in #726 <#726>?
—
Reply to this email directly, view it on GitHub
<#729 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BR4RMV7BHFFPTQL57HRBGLT3DQ54JAVCNFSM6AAAAAB7KDTXJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZSHAZTIMJYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You cannot reopen that PR because this PR is opened (this and that PRs were created from the same branch (or branch with the same name); only one of them can remain opened. You can submit both of your completed PRs (even if they are closed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added form validation for customer name to prevent empty or whitespace-only inputs.
Ensured email addresses follow a valid format using HTML5 input type.
Limited t-shirt color selection to 3 predefined options (Red, Blue, Black).
Restricted t-shirt size selection to 6 fixed sizes (XS, S, M, L, XL, XXL).
I have used HTML only. I have not used any CSS or JavaScript.
Questions
Ask any questions you have for your reviewer.