Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOUTH AFRICA CPT-ITP | LUKE MANYAMAZI | MODULE STRUCTURING AND TESTING | WEEK 3 #212

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Luke-Manyamazi
Copy link

@Luke-Manyamazi Luke-Manyamazi commented Dec 1, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Luke-Manyamazi Luke-Manyamazi added the Needs Review Participant to add when requesting review label Dec 1, 2024
function getAngleType(angle) {
let type;

switch (true) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are switching or 'looping' through the possible values of which variable? (Hint - not of true, though I see your idea, you used true inside of switch() so that you always go into this switch construction. But this is not the usual way to use switch).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a second though, I think your approach is valid, though my first though for solving this task would be if-else conditions.

@codrex codrex added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Dec 4, 2024
@Luke-Manyamazi Luke-Manyamazi added the Complete Participant to add when work is complete and review comments have been addressed label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants