-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOUTH AFRICA CPT-ITP | LUKE MANYAMAZI | MODULE STRUCTURING AND TESTING | WEEK 3 #212
base: main
Are you sure you want to change the base?
SOUTH AFRICA CPT-ITP | LUKE MANYAMAZI | MODULE STRUCTURING AND TESTING | WEEK 3 #212
Conversation
function getAngleType(angle) { | ||
let type; | ||
|
||
switch (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are switching or 'looping' through the possible values of which variable? (Hint - not of true, though I see your idea, you used true inside of switch() so that you always go into this switch construction. But this is not the usual way to use switch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a second though, I think your approach is valid, though my first though for solving this task would be if-else conditions.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.