Glasgow_Class|Shreef_Ibrahim|Structuring _Testing _Datast|Week1_exercise1-update #234

shreefAhmedM · 2024-12-21T13:38:37Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan · 2024-12-22T13:58:37Z

The current branch contains only one modified file.

You need to copy your modified files from branch sprint_1_exercises to this branch. You can download the files in branch sprint_1_exercises from Github.

When you have updated this branch, you can add a "Need Review" label and tag me.

cjyuan

Code is generally good.
I left some comments and suggestions.

cjyuan · 2024-12-23T21:59:37Z

Sprint-1/errors/3.js

@@ -1,9 +1,14 @@
 const cardNumber = 4533787178994213;
-const last4Digits = cardNumber.slice(-4);
+const last4Digits = cardNumber.slice(4);


Have you tried executing this script to see if it works?

Yes it log error => TypeError: cardNumber.slice is not a function.
I have updated the code by Convert the number to a string using .toString()
and Slice(-4) extract the last 4 characters of the string, starting from the end.
now the output of last4Digits correctly stores "4213"

cjyuan · 2024-12-23T22:02:02Z

Sprint-1/exercises/count.js

@@ -1,6 +1,8 @@
 let count = 0;

-count = count + 1;
+count = count++;


Why changed the original code at line 3?
If you want to use ++ operator, you can just write count++ without the assignment operator.

I have updated

cjyuan · 2024-12-23T22:04:30Z

Sprint-1/exercises/decimal.js

@@ -7,3 +7,11 @@ const num = 56.5678;
 // Create a variable called roundedNum and assign to it an expression that evaluates to 57 ( num rounded to the nearest whole number )

 // Log your variables to the console to check your answers
+var wholeNumberPart = Math.floor(num);


It is better to use 'let' than 'var' to declare variable.

I have updated

cjyuan · 2024-12-23T22:05:23Z

Sprint-1/exercises/initials.js

@@ -4,3 +4,5 @@ let lastName = "Johnson";

 // Declare a variable called initials that stores the first character of each string.
 // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.
+var initials =
+  firstName.slice(0, 1) + middleName.slice(0, 1) + lastName.slice(0, 1);


There is a simpler syntax to retrieve the first character from a string.

Strings in JavaScript can be treated like arrays of characters, so i have updated using firstName[0] + middleName[0] + lastName[0], now i think more accrued

cjyuan · 2024-12-23T22:07:14Z

Sprint-1/exercises/paths.js

@@ -16,3 +16,6 @@ console.log(`The base part of ${filePath} is ${base}`);

 // Create a variable to store the dir part of the filePath variable
 // Create a variable to store the ext part of the variable
+
+var dir = filePath.slice(0, lastSlashIndex);
+var ext = base.slice(4);


How would you change your code so that it can also work for file paths like
/path1/.git/filename.js
/path1/path2/package.json
?

I have updated its dynamic now.
1- /path1/.git/filename.js
2- /path1/path2/package.json
the expected output :
The base part files1 and 2 paths are filename.js , package.json
The dir part of file 1 and 2 paths are /path1/.git, /path1/path2
The ext part of file 1 and 2 paths are .js, .json

cjyuan · 2024-12-23T22:08:36Z

Sprint-1/exercises/random.js

+     // The variable num represents a random integer between 1 and 100.
+    //  so each time you run the program, a different integer within the range [1, 100] will be generate.


To test your understanding, how would you write an expression
(without using any variable in the expression) that yields a random
integer between -5 and 3 (including -5 and 3)?

Math.floor(Math.random() * (3 + 5 + 1)) - 5;

cjyuan · 2024-12-23T22:15:23Z

Sprint-1/interpret/time-format.js

 // c) Using documentation, explain what the expression movieLength % 60 represents
+//   The remainder (%) operator returns the remainder left over when one operand is divided by a second operand. It always takes the sign of the dividend.fb


What does this particular remainder represent?

Represents the remaining minutes that are not part of a full hour when the movie length is expressed in hours and minutes.

cjyuan · 2024-12-23T22:17:12Z

Sprint-1/interpret/time-format.js


 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// its using tamplat to store variable and any tex /the better name could be time


time may also imply value like "8:45 pm" or "20:45". Can you come out with a more suitable name?

i think. movieRuntime

cjyuan · 2024-12-23T22:21:24Z

Sprint-1/interpret/to-pounds.js

+// this will finsh i 4 steps A/initialises a string variable/B- git the value (paddedPenceNumberString.length - 2 == 1)and  take us arg
+//  C/ calc paddedPenceNumberString.substring(1)=="99"  and the resultof padEnd() = 99 asign tp the pence


Can we expect this program to work as intended even if we deleted .padEnd(2, "0") from the code?

yes, it will work because it formatted when added earlier padStart(3, "0").

Apdate sprint1 exercise

8b183cf

shreefAhmedM added the Needs Review Participant to add when requesting review label Dec 21, 2024

shreefAhmedM requested review from cjyuan and SallyMcGrath and removed request for cjyuan December 22, 2024 12:09

cjyuan added 👀 Review Requirements Changes requested to meet requirements and removed Needs Review Participant to add when requesting review labels Dec 22, 2024

shreefAhmedM and others added 2 commits December 23, 2024 06:56

sprint-1 update

3fc5b0a

the sprint1 update

3189099

shreefAhmedM added the Needs Review Participant to add when requesting review label Dec 23, 2024

cjyuan reviewed Dec 23, 2024

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed 👀 Review Requirements Changes requested to meet requirements Needs Review Participant to add when requesting review labels Dec 23, 2024

shreefAhmedM and others added 2 commits December 30, 2024 05:43

the changes implemented

a3636c0

change implemented

52272fe

shreefAhmedM added the Complete Participant to add when work is complete and review comments have been addressed label Dec 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glasgow_Class|Shreef_Ibrahim|Structuring _Testing _Datast|Week1_exercise1-update #234

Glasgow_Class|Shreef_Ibrahim|Structuring _Testing _Datast|Week1_exercise1-update #234

shreefAhmedM commented Dec 21, 2024

cjyuan commented Dec 22, 2024 •

edited

Loading

cjyuan left a comment

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

cjyuan Dec 23, 2024

shreefAhmedM Dec 30, 2024

		// The variable num represents a random integer between 1 and 100.
		// so each time you run the program, a different integer within the range [1, 100] will be generate.

		// c) Using documentation, explain what the expression movieLength % 60 represents
		// The remainder (%) operator returns the remainder left over when one operand is divided by a second operand. It always takes the sign of the dividend.fb


		// e) What do you think the variable result represents? Can you think of a better name for this variable?
		// its using tamplat to store variable and any tex /the better name could be time

		// this will finsh i 4 steps A/initialises a string variable/B- git the value (paddedPenceNumberString.length - 2 == 1)and take us arg
		// C/ calc paddedPenceNumberString.substring(1)=="99" and the resultof padEnd() = 99 asign tp the pence

Glasgow_Class|Shreef_Ibrahim|Structuring _Testing _Datast|Week1_exercise1-update #234

Are you sure you want to change the base?

Glasgow_Class|Shreef_Ibrahim|Structuring _Testing _Datast|Week1_exercise1-update #234

Conversation

shreefAhmedM commented Dec 21, 2024

Learners, PR Template

Changelist

Questions

cjyuan commented Dec 22, 2024 • edited Loading

cjyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjyuan commented Dec 22, 2024 •

edited

Loading