Karla Grajales | Sprint-3 - Module-Structuring-and-Testing-Data | SPRINT 3 #238
Conversation
…ype.test.js and we can run the test
Grajales-K
added
🔑 Priority Key
cjyuan
added
Reviewed
| const rank = input.slice(0, -1); | ||
|
|
||
| // Check if the rank is a valid numeric value or face card | ||
| if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 10) { |
There was a problem hiding this comment.
A string representing a decimal numbers such as "2.3" could still pass this test.
A bulletproof approach would be to check if rank is exactly one of "2", "3", ..., "10" before doing the number conversion.
| } | ||
|
|
||
| // If numerator is equal to denominator, it's not a proper fraction | ||
| if (numerator === denominator) { |
There was a problem hiding this comment.
The condition at line 49 can also handle this case.
|
|
||
| // Calculate the new character code | ||
| // const rotatedCode = (upperLetter.charCodeAt(0) - baseCode + num) % 26 + baseCode; | ||
| const rotatedCode = (upperLetter.charCodeAt(0) - baseCode + num + 26) % 26 + baseCode; |
There was a problem hiding this comment.
If we allow num to be a very "large" negative number (e.g., -1000), we can rewrite line 30 as
const rotatedCode = (upperLetter.charCodeAt(0) - baseCode + num % 26 + 26) % 26 + baseCode;
Note: num % 26 would reduce any value of num to the range [-25, 25].
| }); | ||
|
|
||
| test("password too short", () => { | ||
| expect(passwordValidation("Shor!", existingPasswords)).toBe(false); |
thank you @cjyuan I will have a look this again, thank you so much for your time. |
Grajales-K
added
the
Complete
Learners, PR Template
Self checklist
Changelist
In this project, I learned to create simpler, well-structured functions without overcomplicating them. I focused on interpreting instructions carefully to ensure the code behaves as expected. Additionally, I explored how to install Jest, write test cases, and debug them effectively. I also learned to use assertions to validate functionality and handle errors by throwing them instead of returning them, which helped improve the clarity and reliability of the code.
Questions
Ask any questions you have for your reviewer.