Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608
Conversation
| let initials = `firstname(0)+middlename(0)+lastname(0)`; | ||
| console.log(initials); |
There was a problem hiding this comment.
Have you tested these code to ensure it works as expected?
There was a problem hiding this comment.
yeah i tested it now and it was not working, but i have fixed it now.
Sprint-1/1-key-exercises/4-random.js
Outdated
| @@ -7,3 +7,8 @@ const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum; | |||
| // Try breaking down the expression and using documentation to explain what it means | |||
| // It will help to think about the order in which expressions are evaluated | |||
| // Try logging the value of num and running the program several times to build an idea of what the program is doing | |||
| Math.random() means it can generates a random decimal number between 0 and 1 | |||
There was a problem hiding this comment.
Phrases like "number in range from 0 to 1" or "between 0 and 1" are not precise enough in a program specification, because they do not clearly state whether the endpoints 0 and 1 are included.
We can use the concise and precise interval notation to describe a range of values.
For example, we can say, "Math.random() returns a random number in the interval [0, 1)"
There was a problem hiding this comment.
thanks for the comment, it now corrected.
| @@ -12,11 +12,12 @@ console.log(`The percentage change is ${percentageChange}`); | |||
| // Read the code and then answer the questions below | |||
|
|
|||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | |||
|
|
|||
| There are 3 function calls on this file: in line 4, 5 and 10. | |||
There was a problem hiding this comment.
There are more than 3 function calls.
There was a problem hiding this comment.
yes you correct cj, there are actually 5 fucntions call
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| To replace all the comma in the string price to just numerical values (10,000 to 10000) |
There was a problem hiding this comment.
Could also use the say "remove the comma in ....".
The whole sentence is not quite grammatically correct. Can you use an AI tool to fix the grammar mistake?
| const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1); removes the trailing p from the penceString, so the value will be "399". | ||
|
|
||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); pads the numeric string with zeros until it 3 digits character Long. value will be "399" and also ensuring consistency of 3 digits value. | ||
|
|
||
| const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2); extracts the pounds part from the padded string by taking all but the last two digits.Here, it will be "3". | ||
|
|
||
| const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"); extracts the last two characters as the pence portion and ensures it is always two digits. | ||
| console.log(`£${pounds}.${pence}`); formats and prints the final price in pounds and pence format, hence it will output "£3.99" |
There was a problem hiding this comment.
-
Why not write the description as comments so that you can still execute the code in the script?
-
Could we expect this program to work as intended for any valid
penceStringif we deleted.padEnd(2, "0")from the code? In other words, do we really need.padEnd(2, "0")in this script?
There was a problem hiding this comment.
No we don't actually need it, the code still worked perfectly without the .padEnd (2, "0").
cjyuan
added
Reviewed
mayowa0-7
added
Needs Review
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| // To remove the comma in the string price to just numerical values (10,000 to 10000) |
There was a problem hiding this comment.
The whole sentence is still not quite grammatically correct. Can you use an AI tool to fix the grammar mistake?
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
i worked on the template in Structuring and Testing Data Sprint-1, by reading and answering the questions where neccessary.
Questions
Ask any questions you have for your reviewer.