Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608

mayowa0-7 · 2025-06-25T20:07:27Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

i worked on the template in Structuring and Testing Data Sprint-1, by reading and answering the questions where neccessary.

Questions

Ask any questions you have for your reviewer.

cjyuan

You have some modified files in "Sprint-3" folders. Can you revert the changes made to the files in that folder to keep this branch clean?

cjyuan · 2025-06-27T13:35:48Z

Sprint-1/1-key-exercises/2-initials.js

+let initials = `firstname(0)+middlename(0)+lastname(0)`;
+console.log(initials);


Have you tested these code to ensure it works as expected?

yeah i tested it now and it was not working, but i have fixed it now.

cjyuan · 2025-06-27T13:38:07Z

Sprint-1/1-key-exercises/4-random.js

@@ -7,3 +7,8 @@ const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;
 // Try breaking down the expression and using documentation to explain what it means
 // It will help to think about the order in which expressions are evaluated
 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+Math.random() means it can generates a random decimal number between 0 and 1


Phrases like "number in range from 0 to 1" or "between 0 and 1" are not precise enough in a program specification, because they do not clearly state whether the endpoints 0 and 1 are included.

We can use the concise and precise interval notation to describe a range of values.
For example, we can say, "Math.random() returns a random number in the interval [0, 1)"

thanks for the comment, it now corrected.

cjyuan · 2025-06-27T13:39:22Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

@@ -12,11 +12,12 @@ console.log(`The percentage change is ${percentageChange}`);
 // Read the code and then answer the questions below

 // a) How many function calls are there in this file? Write down all the lines where a function call is made
-
+There are 3 function calls on this file: in line 4, 5 and 10.


There are more than 3 function calls.

yes you correct cj, there are actually 5 fucntions call

cjyuan · 2025-06-27T13:44:02Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+To replace all the comma in the string price to just numerical values (10,000 to 10000)


Could also use the say "remove the comma in ....".

The whole sentence is not quite grammatically correct. Can you use an AI tool to fix the grammar mistake?

cjyuan · 2025-06-27T13:47:46Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1); removes the trailing p from the penceString, so the value will be "399".
+
+const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); pads the numeric string with zeros until it 3 digits character Long. value will be "399" and also ensuring consistency of 3 digits value.
+
+const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2); extracts the pounds part from the padded string by taking all but the last two digits.Here, it will be "3".
+
+const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0");  extracts the last two characters as the pence portion and ensures it is always two digits.
+  console.log(`£${pounds}.${pence}`); formats and prints the final price in pounds and pence format, hence it will output "£3.99" 


Why not write the description as comments so that you can still execute the code in the script?

Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code? In other words, do we really need .padEnd(2, "0") in this script?

No we don't actually need it, the code still worked perfectly without the .padEnd (2, "0").

cjyuan

All the other changes look good.

Can you rephrase the description in Sprint-1/3-mandatory-interpret/1-percentage-change.js?

cjyuan · 2025-06-28T15:45:23Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+// To remove the comma in the string price to just numerical values (10,000 to 10000)


The whole sentence is still not quite grammatically correct. Can you use an AI tool to fix the grammar mistake?

cjyuan · 2025-07-03T01:27:11Z

Change look good! Well done.

mayowa0-7 added 9 commits June 14, 2025 15:28

i have been able to write code for different angles.

a9e3fa6

edited the template

3d83018

added a comment about line 3

e8b3747

i committed the names

a7e94be

created variables for dir and ext part

ebd4871

meaningof each terms are explained

51be3c3

mandatory errors have being corrected

406ec49

edited the mandatory interpret template

b57c503

explainedthe pounds formating using template provided

b8e21a5

mayowa0-7 added the Needs Review Participant to add when requesting review label Jun 25, 2025

cjyuan reviewed Jun 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 27, 2025

mayowa0-7 added 3 commits June 28, 2025 01:59

all corrections and comment have being corrected and adttented to

06c6392

All changes have been made to the corrections

6b032fe

i fixed branch in proper order

cfb2012

mayowa0-7 added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 28, 2025

cjyuan reviewed Jun 28, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 28, 2025

acknowledge and corrected the comment

56c4b8b

mayowa0-7 added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 2, 2025

cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jul 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608

Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608

Uh oh!

mayowa0-7 commented Jun 25, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jun 27, 2025 •

edited

Loading

Uh oh!

mayowa0-7 Jun 28, 2025 •

edited

Loading

Uh oh!

cjyuan Jun 27, 2025

Uh oh!

mayowa0-7 Jun 28, 2025

Uh oh!

cjyuan Jun 27, 2025

Uh oh!

mayowa0-7 Jun 28, 2025

Uh oh!

cjyuan Jun 27, 2025

Uh oh!

mayowa0-7 Jun 28, 2025

Uh oh!

cjyuan Jun 27, 2025

Uh oh!

mayowa0-7 Jun 28, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jun 28, 2025

Uh oh!

cjyuan commented Jul 3, 2025

Uh oh!

Uh oh!

		let initials = `firstname(0)+middlename(0)+lastname(0)`;
		console.log(initials);

		// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
		To replace all the comma in the string price to just numerical values (10,000 to 10000)

		// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
		// To remove the comma in the string price to just numerical values (10,000 to 10000)

Uh oh!

Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608

Are you sure you want to change the base?

Sheffield | May-2025 | Mayowa Fadare | Structuring and Testing Data Sprint-1 #608

Uh oh!

Conversation

mayowa0-7 commented Jun 25, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayowa0-7 Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Jul 3, 2025

Uh oh!

Uh oh!

cjyuan Jun 27, 2025 •

edited

Loading

mayowa0-7 Jun 28, 2025 •

edited

Loading