London | May-2025 | Fatima Z Belkedari | Module Structuring and Testing Data | Sprint 2 #610

Farah-Stu · 2025-06-25T23:28:36Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

a-robson

Overall this very good. You've obviously picked up a lot of Javascript fundamentals. However there are a few little slips here and there. Running the code would help you catch these. Let me know if you need me to expand or clarify my comments.

a-robson · 2025-07-04T14:51:05Z

Sprint-2/1-key-errors/0.js

+
+function capitlise(str) {
+  let capitalise =`${str[0].toUpperCase()}${str.slice(1)}`;
+  return str;
+}


What is the result of running this code with a test string e.g. 'hello'?

The result would be Hello with a capital letter

Is the right variable being returned?

No. I should return capitalise. Thank you

a-robson · 2025-07-04T14:53:46Z

Sprint-2/2-mandatory-debug/0.js

+
+function multiply(a, b){
+  return (a*b);
+}
+console.log(`The result of multiplying 10 and 32 is ${multiply(10*32)}`);


Comment out the original faulty code and try running your code. Can you see a problem with the test?

Yes, the problem is that I should add comma instead of *.

Yes, well-spotted.

a-robson · 2025-07-04T14:56:28Z

Sprint-2/2-mandatory-debug/1.js

 // Finally, correct the code to fix the problem
 //  =============> write your new code here
+
+function sum(a, b){
+  return(a+b);


Are the brackets inside the function required here?

They are optional with the return function but I will remove them.

Yes you are right. Sometimes we do want to use brackets that aren't strictly necessary because it can make complicated expressions easier to read but in this case I think it creates clutter and I wanted to be sure you knew they were optional.

a-robson · 2025-07-04T15:00:19Z

Sprint-2/2-mandatory-debug/2.js

+console.log(`The last digit of 42 is ${getLastDigit(42)}`);
+console.log(`The last digit of 105 is ${getLastDigit(105)}`);
+console.log(`The last digit of 806 is ${getLastDigit(806)}`);


There is an issue in the console.log statements. Can you spot it?

No. I can't spot it. Because I already fixed the code by adding a parameter number between brackets . So when you run the code it will give you the last digit of 42 which is 2 , and so on. If I am wrong ,enlighten me please. Thank you

Is getLastDigit the name of your function?

Oh! I see. My function name is getTheLastDigit.

Yes, well-done. Just as a side note - typically getLastDigit would be preferred to getTheLastDigit as a function name because 'The' doesn't really add meaning and it's good to be concise. No need to change it though.

Ok.I will take that into account . Thank you

a-robson · 2025-07-04T15:01:16Z

Sprint-2/3-mandatory-implement/1-bmi.js

+}
+console.log(calculateBMI(55, 1.65));


How might we amend the code so the output is displayed to 1 decimal place?

By simply adding toFixed(1).

Yes, toFixed(1) is the right method to use but how can we use it so that the function returns the BMI to one decimal place?

Adding it to the following code: console.log(calculateBMI(55, 1.65).toFixed(1));

Okay, but this means every time we call the function we have to apply toFixed(1) to the output. But if we use toFixed(1) inside the function?

Ok. I see. I used it inside the function:
function calculateBMI(weight, height) {
const square =weight/ (height*height);
return square.toFixed(1);
I hope it is fixed now.

Great. I'll change label to complete. But if you have any questions let me know.

a-robson · 2025-07-04T15:02:47Z

Sprint-2/3-mandatory-implement/2-cases.js

@@ -14,3 +14,12 @@
 // You will need to come up with an appropriate name for the function
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function ToUpperSnakeCase(input){


Does this function name follow the usual camelCase convention?

No, it does not. "camelCase" starts with a small lowercase letter and each new word starts with capital letter.

davidbrown2324 · 2025-07-07T10:03:11Z

Please remove the Reviewed label when you add the Needs Review label, to make it more clear what state this PR is in.

a-robson · 2025-07-08T14:14:07Z

If you could just look again at the BMI exercise and amend the code we could move this to complete.

Farah-Stu · 2025-07-09T22:43:46Z

Thank you for your support.

Farah-Stu added 13 commits June 23, 2025 23:47

fixing the code's error

4bd74de

updating the changes

44ace2e

fixing the percentage error exercises

25fabb9

updating key errors

a821c8a

updating mandatory debug

09946c7

debugging and fixing the errors

4aa5b75

fixing the errors

d1108da

Calculating BMI

ab80854

Uppersnake case

c75bbc9

Update to.pounds

1a41b29

update time-format

312181c

updating time format

55fd5b6

fixing a typo

57ddac2

Farah-Stu added the Needs Review Participant to add when requesting review label Jun 25, 2025

Farah-Stu mentioned this pull request Jul 3, 2025

London ITP MAY 2025 |Structuring and Testing Data | Fatima Zohra Belkedari | Step 2 Farah-Stu/My-Coursework-Planner#51

Open

a-robson added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 4, 2025

a-robson reviewed Jul 4, 2025

View reviewed changes

a-robson added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 4, 2025

Farah-Stu added 5 commits July 4, 2025 19:51

update the upperCase file

3da97a3

debugging and fixing the issue

90d05b0

removing the brackets

13e562d

updating the last digit file

7e4b084

Amending to decimal number

32fa914

Farah-Stu added the Needs Review Participant to add when requesting review label Jul 4, 2025

fixing conole.log issue

2ee4da2

Farah-Stu added the 👀 Review Requirements Changes requested to meet requirements label Jul 6, 2025

Farah-Stu removed the Reviewed Volunteer to add when completing a review label Jul 7, 2025

a-robson added Reviewed Volunteer to add when completing a review and removed 👀 Review Requirements Changes requested to meet requirements Needs Review Participant to add when requesting review labels Jul 8, 2025

Updating the toFixed function

5a9be36

a-robson added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jul 9, 2025

Uh oh!

London | May-2025 | Fatima Z Belkedari | Module Structuring and Testing Data | Sprint 2 #610

Are you sure you want to change the base?

London | May-2025 | Fatima Z Belkedari | Module Structuring and Testing Data | Sprint 2 #610

Uh oh!

Conversation

Farah-Stu commented Jun 25, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

a-robson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidbrown2324 commented Jul 7, 2025

Uh oh!

a-robson commented Jul 8, 2025

Uh oh!

Farah-Stu commented Jul 9, 2025

Uh oh!

Uh oh!