Skip to content

LONDON| MAY 2025 | HAKAN MURAT KAVUT | Module-Structuring-and-Testing-Data - Sprint 3 #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

LONDON| MAY 2025 | HAKAN MURAT KAVUT | Module-Structuring-and-Testing-Data - Sprint 3 #611

wants to merge 29 commits into from

Conversation

hmkavut
Copy link

@hmkavut hmkavut commented Jun 26, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

In this PR, I implemented function in Sprint 3 folder and test cases are written for these functions

Questions

Ask any questions you have for your reviewer.

hmkavut added 19 commits June 6, 2025 19:07
@hmkavut
Add description to count.js
7df63de
@hmkavut
Writing to initials variable assignment value.
160492f
@hmkavut
Creating dir and ext variable
c1a5098
@hmkavut
Explanation of random
19ff93a
@hmkavut
fixing error in mandatory errors
17e9a86
@hmkavut
Questions in percentage-change are answered
6bfb125
@hmkavut
time format questions are answered
9eae4db
@hmkavut
pound format questions are answered
21a6fe1
@hmkavut
strech explore questions are answered
a6a69ab
@hmkavut
First bug is fixed and interpreted
dbbdab3
@hmkavut
second error is fixed and interpretted.
d8d315c
@hmkavut
Third problem is fixed
9643e13
@hmkavut
Mandatory debug session is completed.
58cad7d
@hmkavut
removed / at the end
f6f291b
@hmkavut
mandatory implement part is finished
94bb164
@hmkavut
Strech-extend is completed and removed console.log in time-format.
81bff9c
@hmkavut
branch id prepared for sprint 3 and first part is implemented
6dd1aa9
@hmkavut
part 3 is completed
5f4d25e
@hmkavut
Sprint 3 tasks are completed
476b8aa
@hmkavut
Copy link
Author

hmkavut commented Jun 26, 2025

PASS Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
PASS Sprint-3/3-mandatory-practice/implement/repeat.test.js
PASS Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
PASS Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
PASS Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
PASS Sprint-3/3-mandatory-practice/implement/count.test.js

Test Suites: 7 passed, 7 total
Tests: 29 passed, 29 total
Snapshots: 0 total
Time: 0.705 s, estimated 1 s
Ran all test suites.

@hmkavut hmkavut added the Needs Review Participant to add when requesting review label Jun 26, 2025
@hmkavut hmkavut mentioned this pull request Jun 26, 2025
Open
cjyuan
cjyuan reviewed Jul 6, 2025
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 6, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 6, 2025

Can you also include a brief description of this PR in the "Changelist" section?
image

@hmkavut
Copy link
Author

hmkavut commented Jul 7, 2025

Hi @cjyuan,

I updated my PR based on your comments and I edited changelist part.

@hmkavut hmkavut added the Needs Review Participant to add when requesting review label Jul 7, 2025
cjyuan
cjyuan reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a few comments (they are hidden by default because there were too many comments).

image

These few files could still use some improvements.

  • Sprint-3/2-mandatory-rewrite/3-get-card-value.js
  • Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
  • Sprint-3/3-mandatory-practice/implement/count.js
  • Sprint-3/4-stretch-investigate/password-validator.test.js

@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Jul 7, 2025
@hmkavut
Copy link
Author

hmkavut commented Jul 8, 2025

Sorry about that now I fixed them. I hope

@hmkavut hmkavut added the Needs Review Participant to add when requesting review label Jul 8, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 8, 2025

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmkavut @cjyuan