Skip to content

WM | May-2025 | Abdullah Saleh | Sprint-3 #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

3bdullah-saleh
Copy link

@3bdullah-saleh 3bdullah-saleh commented Jun 30, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@3bdullah-saleh 3bdullah-saleh added the Needs Review Participant to add when requesting review label Jun 30, 2025
@3bdullah-saleh 3bdullah-saleh changed the base branch from coursework/sprint-3 to main June 30, 2025 11:06
Copy link

@sathudeva7 sathudeva7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always validate input types (string/number) when writing functions that expect numbers.

function isProperFraction(numerator, denominator) {
    if (denominator === 0) return "Undefined";
    else if (numerator < denominator) return true;
    else return false;
}
``` check the type of input variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants