Glasgow | ITP May -25 | Mirabelle Morah | Module-Structuring-and-Testing-Data | Coursework/sprint-3 #628
Conversation
mirabellemorah
added
📅 Sprint 3
| if (numerator < denominator) return true; | ||
| if (numerator >= denominator) return false; |
There was a problem hiding this comment.
In mathematics, -A/B == A/-B == -(A/B), and -A/-B == A/B for any integers A and B (B ≠ 0).
They represent a proper fraction if A < B and A ≠ 0 and B ≠ 0.
So isProperFraction(-4, 3) should return false because 4 >= 3.
Consider comparing the absolute value of the numerator and the denominator instead.
We can also use else at line 13 to handle any number that does not satisfy the condition of the if statement at line 12.
| const num = Number(rank); | ||
| if (num >= 2 && num <= 9) return num; | ||
|
|
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "00_02".
Does your function return the value you expected from each of the following function calls?
getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("00_02♠");
| test("should return 5 for 5 of Hearts", () => { | ||
| const fiveofHearts = getCardValue("5♥"); | ||
| expect(fiveofHearts).toEqual(5); | ||
| }); | ||
|
|
There was a problem hiding this comment.
When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.
For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as
test("should return the value of number cards (2-10)", () => {
expect(getCardValue("2♣︎")).toEqual(2);
expect(getCardValue("5♠")).toEqual(5);
expect(getCardValue("10♥")).toEqual(5);
// Note: We could also use a loop to check all values from 2 to 10.
});
| test("should return 10 for Jack of Diamonds", () => { | ||
| const jackofDiamonds = getCardValue("J♦"); | ||
| expect(jackofDiamonds).toEqual(10); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We could generalise this test to "should return 10 for face cards (J, Q, K)" and check all three ranks J, Q, K).
|
|
||
| return ( | ||
| num + | ||
| (suffixes[(remainder - 20) % 10] || suffixes[remainder] || suffixes[0]) |
There was a problem hiding this comment.
Can you explain how this expression work?
| test("should return '2nd' for 2", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| }); |
There was a problem hiding this comment.
To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.
For example, we can prepare a test for numbers 2, 22, 132, etc. as
test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
expect( getOrdinalNumber(2) ).toEqual("2nd");
expect( getOrdinalNumber(22) ).toEqual("22nd");
expect( getOrdinalNumber(132) ).toEqual("132nd");
});
Can you update the tests in this script so that they cover all possible valid integers?
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Provided answers to sprint 3
Questions
Nil